Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBEX GUI: 'Apply Changes' button indicates changes have been made when switching instruments #8067

Open
2 tasks
danielmaclaren opened this issue Oct 19, 2023 · 1 comment · Fixed by #8171 · May be fixed by ISISComputingGroup/ibex_gui#1669
Open
2 tasks

IBEX GUI: 'Apply Changes' button indicates changes have been made when switching instruments #8067

danielmaclaren opened this issue Oct 19, 2023 · 1 comment · Fixed by #8171 · May be fixed by ISISComputingGroup/ibex_gui#1669
Assignees
@zsoltkebel @danielmaclaren
Labels
5 bug
Milestone
SPRINT_2023_11_30

Comments

@danielmaclaren
Copy link
Contributor

Where?

/ibex_gui

The issue appears to be caused by the cached values of one insturment being compared to those of the insturment it was switched to, resulting in a perceived change.

Reproducible?

Yes

To Reproduce

If you switch from the local instument to an instrument where changes have been added to any of the DAE panels, and then switch back to your local instrument, the 'Apply Changes' button will appear to be yellow which indicated that a change as been made within the DAE Panels, although no change has occured.

image

Acceptance criteria

  • Switching between instruments does no result in 'Apply Changes' appearing yellow
  • Changes made to local instrument's DAE panel will result in the 'Apply Changes' button appearing yellow
@danielmaclaren danielmaclaren self-assigned this Oct 19, 2023
@danielmaclaren danielmaclaren changed the title IBEX GUI: 'Apply Changes' button indicates changes have been made when switching insturments IBEX GUI: 'Apply Changes' button indicates changes have been made when switching instruments Jan 4, 2024
@danielmaclaren danielmaclaren linked a pull request Jan 8, 2024 that will close this issue
Open
5 tasks
This was linked to pull requests Jan 8, 2024
Ticket 8067 switch instruments ISISComputingGroup/ibex_gui#1669
Open
ticket_8067 #8171
Merged
@github-actions github-actions bot added ready and removed review labels Jan 8, 2024
@github-actions github-actions bot added review and removed ready labels Jan 8, 2024
@danielmaclaren danielmaclaren added this to the SPRINT_2023_11_30 milestone Jan 10, 2024
@LowriJenkins
Copy link
Contributor

I can reproduce this issue on release 14.0.0, there appears to be an unmerged linked pullrequest?

@LowriJenkins LowriJenkins reopened this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zsoltkebel zsoltkebel

@danielmaclaren danielmaclaren

Labels
5 bug
Projects
None yet
Milestone
SPRINT_2023_11_30
Development

Successfully merging a pull request may close this issue.

ticket_8067 ISISComputingGroup/IBEX
Ticket 8067 switch instruments ISISComputingGroup/ibex_gui
4 participants
@KathrynBaker @zsoltkebel @LowriJenkins @danielmaclaren