Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove asynchat/asyncore and use asyncio instead #320

Open
3 tasks
rerpha opened this issue Nov 13, 2024 · 1 comment
Open
3 tasks

remove asynchat/asyncore and use asyncio instead #320

rerpha opened this issue Nov 13, 2024 · 1 comment

Comments

@rerpha
Copy link
Contributor

rerpha commented Nov 13, 2024

If we want to use python >=3.12 we need to remove this as it's been deprecated until then and completely removed in 3.12 onwards.

it's currently used by the stream handler, #306 says a bit about this and how we might change it to suit.

acceptance criteria

  • asynchat and asyncore are removed from use in favour of asyncio
  • our python testing matrix tests against 3.12 and beyond
  • the pyproject.toml is updated to use >=3.10 as its python-versions
@Tom-Willemsen
Copy link
Contributor

Short term fix for 3.12 could be to use a shim (https://pypi.org/project/pyasynchat/), but should still do the refactor towards standard asyncio longer term

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants