Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest using INCBIN instead of INCLUDE if a file is not valid UTF-8 #3

Open
ISSOtm opened this issue May 27, 2024 · 1 comment
Open

Comments

@ISSOtm
Copy link
Owner

ISSOtm commented May 27, 2024

help: This looks like a binary file. Have you tried `INCBIN bg_tiles.2bpp` instead?
@Rangi42
Copy link

Rangi42 commented Dec 7, 2024

I've more frequently run into the opposite problem, INCBINning a file I meant to INCLUDE. Maybe it would be appropriate to do filename detection, e.g. warning for INCBIN "*.inc" or INCBIN "*.asm"; or even tracking which extensions have been INCLUDEd and INCBINned before, and warning if an extension is suddenly used in the opposite way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants