Skip to content

Commit efbbe90

Browse files
committed
refactor: standardize YAML strings and remove unused rules
1 parent 0744413 commit efbbe90

6 files changed

+15
-21
lines changed

.editorconfig

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -439,9 +439,4 @@ dotnet_naming_style.interface_pascal_case.capitalization = pascal_case
439439

440440
[Assets/Tests/StyleTest/IgnoreStyleTest.cs]
441441

442-
dotnet_naming_rule.private_fields.style = camel_case
443-
dotnet_naming_rule.private_fields.symbols = private_fields
444-
dotnet_naming_symbols.private_fields.applicable_kinds = field
445-
dotnet_naming_symbols.private_fields.applicable_accessibilities = private
446-
447-
dotnet_naming_style.camel_case.capitalization = camel_case
442+
dotnet_diagnostic.IDE1006.severity = error

.github/workflows/build-package-exporter.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,4 +155,4 @@ jobs:
155155
new_file="./${{ needs.build-package.outputs.package-name }}"
156156
latest_release="${{ needs.latest-release.outputs.tag }}"
157157
gh release upload "$latest_release" "$new_file"
158-
echo "::notice title=Uploaded new asset::$new_file"
158+
echo "::notice title=Uploaded new asset::$new_file"

.github/workflows/build-release_merge.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,4 +109,4 @@ jobs:
109109
BOT_APP_ID: ${{ secrets.BOT_APP_ID }}
110110
BOT_PRIVATE_KEY: ${{ secrets.BOT_PRIVATE_KEY }}
111111
with:
112-
branch: ${{ github.ref }}
112+
branch: ${{ github.ref }}

.github/workflows/build-release_merge_package.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,4 +132,4 @@ jobs:
132132
BOT_APP_ID: ${{ secrets.BOT_APP_ID }}
133133
BOT_PRIVATE_KEY: ${{ secrets.BOT_PRIVATE_KEY }}
134134
with:
135-
branch: ${{ github.ref }}
135+
branch: ${{ github.ref }}

.github/workflows/reusable-check-editorconfig.yaml

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,30 @@
1-
name: "(Reusable) Check .editorconfig"
1+
name: (Reusable) Check .editorconfig
22

33
on:
44
workflow_call:
55
inputs:
66
ref:
7-
description: "Specify a branch or commit ID"
7+
description: 'Specify a branch or commit ID'
88
required: true
99
type: string
1010
max-retries:
11-
description: "Maximum number of retries if API call fails"
11+
description: 'Maximum number of retries if API call fails'
1212
required: false
1313
type: string
14-
default: "3"
14+
default: '3'
1515
retry-delay:
16-
description: "Delay in seconds between retries"
16+
description: 'Delay in seconds between retries'
1717
required: false
1818
type: string
19-
default: "5"
19+
default: '5'
2020
fail-on-missing:
21-
description: "Fail the workflow if .editorconfig does not exist"
21+
description: 'Fail the workflow if .editorconfig does not exist'
2222
required: false
2323
type: boolean
2424
default: true
2525
outputs:
2626
exists:
27-
description: "Indicates whether the .editorconfig file exists"
27+
description: 'Indicates whether the .editorconfig file exists'
2828
value: ${{ jobs.check-editorconfig.outputs.exists }}
2929

3030
permissions:
@@ -49,10 +49,9 @@ jobs:
4949
5050
echo "Checking for file: $file_path in the checked-out repository..."
5151
52-
success=false
5352
if [ -f "$file_path" ]; then
5453
echo "::notice::.editorconfig file exists."
55-
success=true
54+
success=1
5655
else
5756
echo "::warning::.editorconfig file does not exist."
5857
if [ "$fail_on_missing" = "true" ]; then

.github/workflows/reusable-lint-cs-files.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
workflow_call:
55
inputs:
66
ref:
7-
description: "Specify a branch or commit ID"
7+
description: 'Specify a branch or commit ID'
88
required: true
99
type: string
1010
editorconfig-branch:
@@ -222,4 +222,4 @@ jobs:
222222
- name: Cleanup temporary files
223223
if: ${{ steps.violations-log.outputs.exits == '1' && always() }}
224224
run: |
225-
rm -f TempProject.csproj convert_to_sarif.py output.log output.sarif || true
225+
rm -f TempProject.csproj convert_to_sarif.py output.log output.sarif || true

0 commit comments

Comments
 (0)