Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify consistency of implementation of ProjOuterProdTTN with ProjTTN #134

Open
b-kloss opened this issue Feb 2, 2024 · 0 comments
Open

Comments

@b-kloss
Copy link
Contributor

b-kloss commented Feb 2, 2024

In #132, the functionality of representing an operator of the format O=A|v><v|A^dag is introduced with ProjOuterProdTTN, which should behave consistent with ProjTTN for a general operator W. This type supersedes ProjTTNApply which was designed to give access to environments of A|b>, with A::AbstractTTN,B::AbstractTTN projected into the n-site tangent-space of another psi:AbstractTTN (the latter being the one which is usually optimized, e.g. in the case of variational compression of A|b>). The original functionality of ProjTTNApply is available for ProjOuterProdTTN via contract_ket instead of the usual contract.
Going forward, it should be checked whether the definitions and functions of ProjOuterProdTTN are designed transparently, or whether there are logical inconsistencies inherited from the design of ProjTTNApply. Furthermore, tests should be added as to whether complex arguments are handled properly (current tests are performed on real-valued AbstractTTN as input).
It would make sense to adress this together with #133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant