-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic external audio file support #127
Comments
Alternatively, on IEW Discord, an idea came to me: making a separate package for reading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently when passing externally indexed files (like for example
dgi
ord2v
files), FileInfo2 will not include any audio. I'd like for there to be an automatic check in thepah
's directory for any externally demuxed audio.My idea is as follows:
audios
is empty (ideally prior to trimming and whatnot)a_src
. If not, use the first file found.23Why the current implementation doesn't work
Right now, users can set an
a_src
themselves. But that doesn't result in a usable audio node for previewing. So if for example you're processing an episode in a DVD that's not at the start, you'll get the episode 1 audio unless you loadbas
yourself and handle all the trimming. Handling this automatically is much easier on the user, and falls within the scope of vardautomation's implementations.Caveats
This implementation would probably not work well if the user passed an indexer that automatically indexed using dgindexnv (like for example a hypothetical future rewrite of
lvsfunc.misc.source
), as it would instead try to use the file passed to that indexer to determine the audio situation. I don't know how to best handle that.Footnotes
In the case of dgindex, the demuxed audio will often be called something like
KIBA_91371 T80 2_0ch 48KHz 384Kbps DELAY 0ms.ac3
(whereKIBA_91371.dgi
would be the input file), for example. ↩This can also be changed to be the biggest file, or you could maybe set a hierarchy of what kinds of files would take priority with PCM at the top or something ↩
An alternative would be to add List[VPath] support to it, but that's probably a step too far. Might be something to look at in the future perhaps? ↩
The text was updated successfully, but these errors were encountered: