Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-build image on new mod versions #122

Open
adn77 opened this issue Apr 17, 2024 · 5 comments
Open

Re-build image on new mod versions #122

adn77 opened this issue Apr 17, 2024 · 5 comments

Comments

@adn77
Copy link

adn77 commented Apr 17, 2024

I use icinga/icingaweb2 as base for our install.

Unfortunately the image only gets build when there is a new icingaweb release. As the release of icingaweb is not increased when major plugins are updated (e.g. icingadbweb) I end up manually bind-mounting more current plugin releases into the container.

There is the main tag which appears to be build daily, but I didn't find any CI chain for this.

Is there any chance of building the icingaweb2 image more often or even linking the github actions once an included plugin gets updated?

@oxzi
Copy link
Member

oxzi commented Apr 17, 2024

Unfortunately the image only gets build when there is a new icingaweb release. As the release of icingaweb is not increased when major plugins are updated (e.g. icingadbweb) I end up manually bind-mounting more current plugin releases into the container.

As get-mods.sh is part of the Dockerfile's build and not of the entrypoint, the modules won't get bumped.
This is, as you rightly point out, a problem with outdated modules.

There is the main tag which appears to be build daily, but I didn't find any CI chain for this.

This repository here is used as a GitHub Action within icingaweb2: https://github.com/Icinga/icingaweb2/blob/main/.github/workflows/docker.yml

One easy fix would be to include a GitHub Action Job similar to those in icingaweb2 for github.event_name == 'release' to each module listed in get-mods.sh. Edit: The cron job/Action from icingaweb2 could also rebuild the latest tag on a daily basis.

@Al2Klimov
Copy link
Member

The cron job/Action from icingaweb2 could also rebuild the latest tag

Good idea! IMAO we should let this happen weekly. People on the latest tag expect and want the latest stuff. In case of breaking changes in mods users even have multiple options:

  • Rollback
  • Temporarily mount older mod version

CC @lippserd

@adn77
Copy link
Author

adn77 commented May 27, 2024

I'd be interested in testing your new ini-parsing PR in a :latest tag as well 🙂

@Al2Klimov Al2Klimov changed the title What is the correct docker tag to use Re-build image on new mod versions Jul 17, 2024
@Al2Klimov
Copy link
Member

TODO

  • Await next Icinga-K8s release, see how well its Docker GHA work
  • Based on that, maybe alter our image build process
  • Once the latter is clear, base a new GHA on it, which runs on every mod release

@jan-kantert
Copy link

We also would like a new release with the latest icingadb(-web) version :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants