Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging to journald misses error messages #793

Open
julianbrost opened this issue Aug 22, 2024 · 0 comments
Open

Logging to journald misses error messages #793

julianbrost opened this issue Aug 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@julianbrost
Copy link
Contributor

That's the way we currently typically log errors:

icingadb/pkg/icingadb/ha.go

Lines 392 to 397 in 77ccab2

log := h.logger.Debugw
if attempt > 3 {
log = h.logger.Infow
}
log("Can't update or insert instance. Retrying", zap.Error(err))

When running journalctl -u icingadb, that means you only see something like that:

icingadb[12345]: high-availability: Can't update or insert instance. Retrying

Yes, technically the full error message is logged as well (as extra fields attached to the message) and we did #743, but let's face it: if the most obvious way to view the logs hides the actual error messages, that's a bug.

@julianbrost julianbrost added the bug Something isn't working label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant