Make Java methods public?

[BorntraegerMarc]

What do you think of the idea to make all methods public & static from this class: https://github.com/BorntraegerMarc/cordova-aes256/blob/master/src/android/AES256.java

I could provide a PR.

The benefit would be that we could use the same class for our custom plugin without needing to manually copy & paste the code. Since we need to do something custom with encryption in our native plugin.

[pandiarajan-i2i]

Thanks, @BorntraegerMarc,

Instead of making the plugin method static, we can provide a Util class where all the methods will be static.

[BorntraegerMarc]

that's a good idea @pandiarajan-i2i you want me to create a PR?

[pandiarajan-i2i]

Thanks for your contribution, @BorntraegerMarc

We will add these changes along with the swift version(s) support changes.

[BorntraegerMarc]

OK. Tell me if I can help in any way :)

[pandiarajan-i2i]

@BorntraegerMarc , Could you please check this functionality for swift?

[BorntraegerMarc]

you mean for me to provide a PR to have static methods in swift?

[pandiarajan-i2i]

it may be a pull request or can you confirm whether it's already available as public.

[BorntraegerMarc]

@pandiarajan-i2i so I think these changes need to happen to be able to fully share the code with 3rd parties:

1. Extract this method to a helper method in AES256CBC https://github.com/Ideas2IT/cordova-aes256/blob/master/src/ios/AES256.swift#L60
2. Same for https://github.com/Ideas2IT/cordova-aes256/blob/master/src/ios/AES256.swift#L79

Because without these helper methods we had to manually copy these attributes: https://github.com/Ideas2IT/cordova-aes256/blob/master/src/ios/AES256.swift#L3-L5

tell me if I can help somehow

[pandiarajan-i2i]

Yah you are welcome. If possible we can address the swift versions issues and will add this static method implementation later.

Because, Whenever the new updates to the iOS/Xcode they have removed the support for the previous swift versions. It indirectly forces the previous code implementations.
#18

If we do find some effective solutions then it will be helpful.

[pandiarajan-i2i]

@MukundhanSampath Can you please update your changes?

[BorntraegerMarc]

any progress on this? :) let me know if you need some help...