Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this rp library support refresh_token? #68

Open
johnbyrne7 opened this issue Jun 2, 2023 · 2 comments
Open

Does this rp library support refresh_token? #68

johnbyrne7 opened this issue Jun 2, 2023 · 2 comments

Comments

@johnbyrne7
Copy link

I dont think this (rp) library supports refresh token. In rp_handler.py, method get_access_and_id_token, this line does get a refresh token from the op, in token_resp , when 'offline_access' is added to scopes.

779: token_resp = self.get_tokens(state, client=client)

However, the refresh token is not returned in the dictionary returned by that method, so I dont see how refresh token could be supported

787: return {"access_token": access_token, "id_token": id_token}

am I missing something? any direction would be appreciated

@rohe
Copy link
Contributor

rohe commented Jul 18, 2023

Lower layers of the library do support refresh tokens.
If rp_handler.py doesn't I have change that.

@rohe
Copy link
Contributor

rohe commented Jul 18, 2023

Added refresh_token to what get_access_and_id_token() returns. Presently in the example_fix branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants