Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hrportal): remove update even row styling #35

Closed
wants to merge 5 commits into from

Conversation

tishko0
Copy link
Contributor

@tishko0 tishko0 commented Jan 23, 2025

fixes #27

@yradoeva
Copy link

Looks ok to me.


::ng-deep .igx-grid__tr--even {
Copy link
Contributor

@IMinchev64 IMinchev64 Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to copy this ng-deep override somewhere in the parent project, preferably inside hr-portal-view.component.scss inside src/app/views/hr-portal.

The reason being is this style override works if we run the hr-portal sample as a standalone project, but if we run it as part of a multi-project setup such as grid-demos, the parent project styles override the child styles.

@tishko0 tishko0 changed the base branch from master to vnext January 29, 2025 09:22
@dkamburov dkamburov closed this Jan 29, 2025
@dkamburov dkamburov deleted the ttonev/fix-evenRowStyling branch January 29, 2025 15:36
@dkamburov
Copy link
Collaborator

these chages were done in #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants