Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IgxComboBaseDirective: Refactor combo id setter #14943

Closed
ddaribo opened this issue Oct 23, 2024 · 0 comments · Fixed by #14959, #14966 or #14964
Closed

IgxComboBaseDirective: Refactor combo id setter #14943

ddaribo opened this issue Oct 23, 2024 · 0 comments · Fixed by #14959, #14966 or #14964
Assignees
@ddaribo
Labels
combo version: 17.2.x version: 18.2.x version: 19.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@ddaribo
Copy link
Contributor

ddaribo commented Oct 23, 2024

Related to #14305.

After discussion with @damyanpetev regarding this fix - #14414, the following changes in the IgxComboBaseDirective id setter are suggested:

  1. Clear the selection set entry for the previous id.
  2. Omit the lines closing the dropdown - this could be addressed on application level by setting the overlaySettings.oulet on the templated combos to the grid's outlet. Additionally logged an issue in igniteui-angular-samples to update the Cascading Combos sample with this.
  3. Omit the blur of the combo input.
@ddaribo ddaribo self-assigned this Oct 23, 2024
@ddaribo ddaribo changed the title Refactor combo id setter IgxComboBaseDirective: Refactor combo id setter Oct 23, 2024
@ddaribo ddaribo added version: 18.2.x 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Oct 23, 2024
@ddaribo ddaribo mentioned this issue Oct 25, 2024
Merged
14 tasks
@ddaribo ddaribo added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 25, 2024
This was referenced Oct 28, 2024
Merged
Merged
This was linked to pull requests Oct 28, 2024
refactor(combo): only handle selection set in id setter - 17.2.x #14966
Merged
refactor(combo): only handle selection set in id setter - 18.2.x #14964
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddaribo ddaribo

Labels
combo version: 17.2.x version: 18.2.x version: 19.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
1 participant
@ddaribo