Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate filterGlobal() method #15016

Open
gedinakova opened this issue Nov 6, 2024 · 0 comments
Open

Deprecate filterGlobal() method #15016

gedinakova opened this issue Nov 6, 2024 · 0 comments

Comments

@gedinakova
Copy link
Contributor

Although the method seems to work, it does introduce certain issues with the basic filtering logic and the other filtering UIs.

  1. It stringifies all data and applies string conditions which leads to unpredicatable results for non-string columns/fields
  2. It confuses the Excel Style Filtering UI to an extent that the whole UI looks broken - the column appears as if filtering is applied but the ESF is not capable of displaying the actual filter (the search component is empty, in most of the cases the Custom filter dialog, too)
  3. Applying string conditions on non-string field types breaks the filtering tree rehydration

In general, the method does not seem very practical and useful from an end-user perspective, so we suggest to deprecate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants