Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For_of directive doesn't scroll to next elements in some cases #3482

Closed
MartinKamenov opened this issue Dec 19, 2018 · 0 comments · Fixed by #3543
Closed

For_of directive doesn't scroll to next elements in some cases #3482

MartinKamenov opened this issue Dec 19, 2018 · 0 comments · Fixed by #3543
Assignees
@mpavlinov @MartinKamenov
Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium virtualization ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@MartinKamenov
Copy link
Contributor

MartinKamenov commented Dec 19, 2018 •
edited
Loading

Description

When using scrollNext method in for_of directive the scrolling doesn't apply in some cases.

Steps to reproduce

  1. Set text size to 125%.
  2. Open sample
  3. Press 'next' button twice.
  4. After the first scroll to the next element user can't scroll further.

Result

Scrolling next isn't scrolling in all conditions of heigth in px.

Expected result

Scrolling next should consistently scroll to the next element.

Attachments

scrollNextSample.zip
@MartinKamenov MartinKamenov changed the title For of doesn't scroll to previous elements as expected For_of directive doesn't scroll to previous elements as expected Dec 19, 2018
@MartinKamenov MartinKamenov added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Dec 19, 2018
@MartinKamenov MartinKamenov changed the title For_of directive doesn't scroll to previous elements as expected For_of directive doesn't scroll to next elements in some cases Jan 7, 2019
This was referenced Jan 7, 2019
Merged
Merged
@MartinKamenov MartinKamenov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 8, 2019
@MartinKamenov MartinKamenov mentioned this issue Jan 8, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpavlinov mpavlinov

@MartinKamenov MartinKamenov

Labels
🐛 bug Any issue that describes a bug 🧨 severity: medium virtualization ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding correct calculation for scrollNext. - Master IgniteUI/igniteui-angular
2 participants
@mpavlinov @MartinKamenov