Error while targeting es2017 #3011
Assignees
Labels
🐛 bug
Any issue that describes a bug
🔥 severity: high
🛠️ status: in-development
Issues and PRs with active development on them
version: 6.2.x
Comments
|
Just a note, I only tested this against the Input Group component but not all the other components so it's possible the other components may have similar issues as this one. |
|
Definitely looking forward to this one being fixed! |
|
This is also happening when targeting es2015 |
rkaraivanov
added a commit
that referenced
this issue
Nov 23, 2018
damyanpetev
pushed a commit
that referenced
this issue
Nov 23, 2018
mpavlinov
added
🛠️ status: in-development
damyanpetev
added a commit
that referenced
this issue
Nov 23, 2018
14 tasks
damyanpetev
added a commit
that referenced
this issue
Nov 23, 2018
damyanpetev
added a commit
that referenced
this issue
Nov 26, 2018
Use base class or a token/interface combo for DI child components to avoid Circular dependency warnings and compilation errors in targets es2015 and newer. Added explicit constructors in extending classes as DI metadata doesn't get added otherwise (subject to fixes in ng compiler) Also resolved some general circular refs and updated tests that wouldn't work with es6. Affected: list, calendar, combo, input-group, drop-down, expansion-panel, grids, tabs, time-picker
damyanpetev
added a commit
that referenced
this issue
Nov 26, 2018
Use base class or a token/interface combo for DI child components to avoid Circular dependency warnings and compilation errors in targets es2015 and newer. Added explicit constructors in extending classes as DI metadata doesn't get added otherwise (subject to fixes in ng compiler) Also resolved some general circular refs and updated tests that wouldn't work with es6. Affected: list, calendar, combo, input-group, drop-down, expansion-panel, grids, tabs, time-picker
14 tasks
HristoP96
pushed a commit
that referenced
this issue
Nov 26, 2018
kdinev
pushed a commit
that referenced
this issue
Nov 26, 2018
* refactor(es6): resolve es6+ compile errors and most circular deps #3011 Use base class or a token/interface combo for DI child components to avoid Circular dependency warnings and compilation errors in targets es2015 and newer. Added explicit constructors in extending classes as DI metadata doesn't get added otherwise (subject to fixes in ng compiler) Also resolved some general circular refs and updated tests that wouldn't work with es6. Affected: list, calendar, combo, input-group, drop-down, expansion-panel, grids, tabs, time-picker * fix(hammer-configs): Add Injectable DatePicker/TimePicker HammerConfigs. #3011 (cherry picked from commit 59aed5e)
|
@ig-robstoffers @grosch @QuinntyneBrown We made the fix available in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Created a brand new Angular project and changed the
targetin thetsconfig.jsonfile toes2017. After attempting to add anigx-input-groupthe following error is displayed in the chrome developer console:Changing the
targetback to the defaultes5value causes everything to work as expected.Steps to reproduce
npm installnpm startResult
What is the actual result after following the steps to reproduce?
IgxCalendarDateDirective is not defined error is shown
Expected result
What is the expected result after following the steps to reproduce?
No error is shown and the Input component is rendered.
Attachments
input-sample-seven.zip
The text was updated successfully, but these errors were encountered: