Skip to content

Commit 209b317

Browse files
committed
fix(Scope): aggressively clean up scope on $destroy to minimize leaks
Due to a known V8 memory leak[1] we need to perform extra cleanup to make it easier for GC to collect this scope object. The theory is that the V8 leaks are due to inline caches which are caches built on the fly to speed up property access for javascript objects. By cleaning the scope object and removing all properties, we clean up ICs as well and so no leaks occur. I was able to manually verify that this fixes the problem for the following example app: http://plnkr.co/edit/FrSw6SCEVODk02Ljo8se?p=preview Given the nature of the problem I'm not 100% sure that this will work around the V8 problem in scenarios common for Angular apps, but I guess it's better than nothing. [1] V8 bug: https://code.google.com/p/v8/issues/detail?id=2073 Closes angular#6794
1 parent 9d07796 commit 209b317

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

src/ng/rootScope.js

+13-4
Original file line numberDiff line numberDiff line change
@@ -730,15 +730,24 @@ function $RootScopeProvider(){
730730

731731
forEach(this.$$listenerCount, bind(null, decrementListenerCount, this));
732732

733+
// sever all the references to parent scopes (after this cleanup, the current scope should
734+
// not be retained by any of our references and should be eligible for garbage collection)
733735
if (parent.$$childHead == this) parent.$$childHead = this.$$nextSibling;
734736
if (parent.$$childTail == this) parent.$$childTail = this.$$prevSibling;
735737
if (this.$$prevSibling) this.$$prevSibling.$$nextSibling = this.$$nextSibling;
736738
if (this.$$nextSibling) this.$$nextSibling.$$prevSibling = this.$$prevSibling;
737739

738-
// This is bogus code that works around Chrome's GC leak
739-
// see: https://github.com/angular/angular.js/issues/1313#issuecomment-10378451
740-
this.$parent = this.$$nextSibling = this.$$prevSibling = this.$$childHead =
741-
this.$$childTail = null;
740+
// This is bogus code that works around V8's memory leak coming from ICs
741+
// see: https://code.google.com/p/v8/issues/detail?id=2073#c26
742+
//
743+
// for more info also see:
744+
// - https://github.com/angular/angular.js/issues/6794#issuecomment-38648909
745+
// - https://github.com/angular/angular.js/issues/1313#issuecomment-10378451
746+
for (var prop in this) {
747+
if (hasOwnProperty.call(this, prop)) {
748+
this[prop] = null;
749+
}
750+
}
742751
},
743752

744753
/**

0 commit comments

Comments
 (0)