-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base64 Icons are extremely lengthy #363
Comments
In my opinion, probably the best option is to make a pull request to the simple icons github page at https://github.com/simple-icons/simple-icons to add the logo so that it can be used using the API given by shields.io. I have tried using a image that has been hosted in another site and input the link in the logo=XXXXXXXX part and I don't think it work.. |
You speak the truth, @thechrisandrew. That is probably the best and ostensibly, the most sanitary form of action to take right now. 👍🏽 😄 The way shields API works, I doubt using an arbitrary link would turn out the way we want it. Have you attempted to contribute to the Simple Icons project? |
I haven't had the chance to contribute to the simple-icons project yet, they do have a very thorough contributions.md, its almost intimidating 😂 |
Yikes! 😆 Looking at it right now. We find ourselves in between the mountain and the red sea... would take a stab at contributing one of these days... sooner than later i hope. |
Discussed in #362
Originally posted by kohasummons May 9, 2022
Often times we get PRs that contribute to our growing stash of badges. While we appreciate these contributions - and contributors, there is a sinister issue that has been leaking into some of these contributions - base64 logos make the URL extremely long.
A little background to offer context, markdown-badges leverage the @shields.io API. The shields API utilizes the simple icons project to provide icons for badges. For quite a while these have worked quite well until there was a need for badges which simple icon has no icons in its stash for. Hence, we leverage the shields.io option to use a base64 encoding to represent the icons. Here's an example of what that should look like #342
The badge:

The URL that cooked the badge:
Yes, it does render the badge well yet imagine a bunch of these crawling around in our repo. Would be quite messy and the risk for errors would exponentially rise. As it stands right now, this is the way to offer icons not provided by simple icons.
How best should we handle this?
The text was updated successfully, but these errors were encountered: