Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix/alias] vite 및 jest alias에서 @atoms 누락된 부분 추가 #22

Merged
merged 7 commits into from
Mar 21, 2021
Merged

[fix/alias] vite 및 jest alias에서 @atoms 누락된 부분 추가 #22

merged 7 commits into from
Mar 21, 2021

Conversation

dididy
Copy link
Collaborator

@dididy dididy commented Mar 10, 2021

resolve #5

SeonHyungJo and others added 5 commits February 12, 2021 15:55
@SeonHyungJo
Merge pull request #1 from Im-D/develop
7fef77f 
초기환경설정
@SeonHyungJo
Update issue templates
83af9c8
@SeonHyungJo
Merge pull request #2 from Im-D/develop
ab439c2 
컴포넌트 초기화 및 SASS 관련 설정
@dididy
Merge branch 'master' of https://github.com/Im-D/your-voice-front int…
61083e6 
…o fix/alias
@dididy
fix(alias): atoms에 대한 jest 및 vite config alias 설정 제대로 변경
982bcd6 
- 지난번에 제대로 잡아놓은줄 알았는데 아니었음
- 정상 작동 하도록 수정
@dididy dididy self-assigned this Mar 10, 2021
@SeonHyungJo SeonHyungJo changed the base branch from master to develop March 10, 2021 16:15
@dididy
style: jest.config.js 컨벤션 통일
8f452ee 
- 싱글쿼트와 더블쿼트 혼용된 부분 수정
- prettier로 정리
@dididy dididy requested review from SeonHyungJo and BKJang and removed request for SeonHyungJo March 10, 2021 16:45
@dididy dididy added the 버그 작동이 원할하지 않습니다. label Mar 10, 2021
SeonHyungJo
SeonHyungJo reviewed Mar 11, 2021
View reviewed changes
SeonHyungJo
SeonHyungJo requested changes Mar 11, 2021
View reviewed changes
Copy link
Member

@SeonHyungJo SeonHyungJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인부탁드립니다.

@dididy
refactor(jest): jest.config.js 의 alias 삭제 및 추가
b11b74f 
- molecules 및 organisms 삭제
- @ 및 styles 추가
SeonHyungJo
SeonHyungJo approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@SeonHyungJo SeonHyungJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인합니다.

BKJang
BKJang approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@BKJang BKJang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

@BKJang BKJang merged commit 9566dc5 into develop Mar 21, 2021
@BKJang BKJang deleted the fix/alias branch March 21, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BKJang BKJang BKJang approved these changes

@SeonHyungJo SeonHyungJo SeonHyungJo approved these changes

Assignees

@dididy dididy

Labels
버그 작동이 원할하지 않습니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vite alias가 정상 작동하지 않음
3 participants
@dididy @BKJang @SeonHyungJo