memory leaks #1528
Comments
urban-warrior
pushed a commit
that referenced
this issue
Mar 26, 2019
urban-warrior
pushed a commit
to ImageMagick/ImageMagick6
that referenced
this issue
Mar 26, 2019
|
Thanks for the problem report. We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today. The patch will be available in the beta releases of ImageMagick @ https://www.imagemagick.org/download/beta/ by sometime tomorrow. |
|
Fine, How to get a CVE number? |
|
We have a small development group. We rely on ImageMagick users to request a CVE and post the results here. The developers will continue to focus on bug fixes and enhancements. |
|
CVE-2019-16710 was assigned to this issue. |
mehulagg
pushed a commit
to mehulagg/superproject
that referenced
this issue
Dec 21, 2019
* Update art from branch 'simpleperf-release'
to d6fcd793bddba7f7cc254aed74c27f96c6c25c0a
- Perform SetEvent under the user_code_suspend_count_lock_
We would perform major parts of SetEvent without any synchronization
and perform multiple internal suspensions. This could lead to
inconsistent state or deadlocks.
Test: ./test.py --host
Test: ./art/tools/run-libjdwp-tests.sh --mode=host
Change-Id: Ice2fc94b4f82fcd5938928e8dbf1bdddd29000ab
- Snap for 5437783 from 3fa8b6db7b556035f192d037b35210677250798e to simpleperf-release
Change-Id: I4f4a10bc9554906722399e5165de3e9d9ce8353a
* Update bionic from branch 'simpleperf-release'
to 3e47311e71934a246fb2a69c92afdcd7d06ada9d
- Merge "Snap for 5437783 from 93ea8569495d35c83ff6ef06292159c9056c6cc2 to simpleperf-release" into simpleperf-release
- Snap for 5437783 from 93ea8569495d35c83ff6ef06292159c9056c6cc2 to simpleperf-release
Change-Id: Ia4a271f71c46fb30be103b9ee3d9ecd8a2c179cc
- Merge changes I59a8bc4a,Ic437d352
* changes:
Fix dlsym and dladdr for TLS symbols
Fix BionicAllocator comment
- Merge "Workaround potential access to unmapped stack"
- Fix dlsym and dladdr for TLS symbols
* dlsym: call __tls_get_addr for TLS symbols
* dladdr: skip TLS symbols
Bug: b/123772574
Test: bionic unit tests
Change-Id: I59a8bc4a7d455e1018b0d577b027b6417c8487cd
- Workaround potential access to unmapped stack
Issue:
Process is crashed near the end (startup_handshake_lock.unlock()) in
pthread_create().
The newly created child thread passes this handshake_lock unexpectedly
=> its stack is unmapped & its associated pthread_internal_t data
structure can’t be accessed.
Analysis:
The created child thread should be blocked by startup_handshake_lock.lock()
and enter __futex_wait_ex()
But if the parent thread is in the middle of startup_handshake_lock.unlock():
void unlock() {
if (atomic_exchange_explicit(&state, Unlocked, memory_order_seq_cst) == LockedWithWaiter) { // => the state is modified to Unlocked
// (a) if the child thread is back to running and pass the while() check in Lock::lock()
// (b) the child thread executes its start_routine and then pthread_exit
// (c) the stack of the child thread (where its pthread_internal_t (so the startup_handshake_lock) is located) will be unmapped
__futex_wake_ex(&state, process_shared, 1); // => when the parent thread is back to running
// the “state” & “process_shared” of startup_handshake_lock can’t be accessed (unmapped)
// so the process will be crashed
}
}
Bug: 129744706
Test: Monkey
Change-Id: I55175e8c7ebc2b3b52de8a5602def0667076b974
- Fix BionicAllocator comment
Test: n/a
Bug: none
Change-Id: Ic437d35231b47553add49e20d7ee451d42db710c
* Update build/make from branch 'simpleperf-release'
to 2b84c9fbfa086dbfe1c0c8de65c232ba43ea5a4a
- Merge "Snap for 5437783 from 15d56810ca26f2a35fb1aec3a99fa773f30d29ff to simpleperf-release" into simpleperf-release
- Snap for 5437783 from 15d56810ca26f2a35fb1aec3a99fa773f30d29ff to simpleperf-release
Change-Id: Idd28a47af3ecc0bdacac4cc1c4fdacdd8cecf0ec
- Merge "prebuilt_internal.mk refactoring."
- Merge "Remove 'column' from modules target"
- Remove 'column' from modules target
The standard target modules stopped working when restrictions in
soong were introduced to which binaries are allowed to be used during
builds.
Listing a very large amount of modules in columns does not make it
more readable and harder to work with in tools so just drop it.
Bug: 129800175
Test: make modules
Change-Id: I26040479a03916161fb5d072de1af640d8080c7f
- prebuilt_internal.mk refactoring.
Add cc_prebuilt_internal.mk and java_prebuilt_internal.mk. Now all
buisiness logic lives in individual per-class prebuilt mk files.
Fixes: 128609813
Test: Built and flashed a Pixel device image + TreeHugger
Change-Id: I3827f990642bb7587dc682d1a382b3a1ce22fe66
* Update build/soong from branch 'simpleperf-release'
to 7746f743ea3e6ee69b0e88dcab6f98b149e7aaf4
- Snap for 5437783 from fc453c79f23103d694e9956bacc97bd41084f030 to simpleperf-release
Change-Id: I5e0eb76959d00edc666d0ae3880f484414ef90b1
- Merge "Soong: Add synopsis to vndk_prebuilt_shared module under cc package."
- Soong: Add synopsis to vndk_prebuilt_shared module under cc package.
Added vndk_prebuilt_shared synopsis.
Bug: b/128337482
Test: Generated the documentation and verified that the synopsis
was added to the vndk_prebuilt_shared module.
Change-Id: Id40246de65985b8b3b357744083c1d32c872e2ff
* Update cts from branch 'simpleperf-release'
to e39f8b65791f6a4ee043dae55214287b56c03dc4
- Merge "Snap for 5437783 from 9d40876bf8656fbf2f69b1b07fd6cef985cff469 to simpleperf-release" into simpleperf-release
- Snap for 5437783 from 9d40876bf8656fbf2f69b1b07fd6cef985cff469 to simpleperf-release
Change-Id: Icc2c9509fec0a23627eb8bec7ec68a1f00bbaf2a
- Merge "Add CTS tests for CallQuality and CallAttributes"
- Merge "Update test comments for zic 2019a"
- Merge "Merge "Set preferred device in order to trigger routed device changed event." into pie-cts-dev am: a806a3ec1a"
- Merge "Set preferred device in order to trigger routed device changed event." into pie-cts-dev
am: a806a3ec1a
Change-Id: Id0676eb0df23f339f5b0c211879e1f338e1f2897
- Merge "Set preferred device in order to trigger routed device changed event." into pie-cts-dev
- Merge "Camera ITS: Request focus distance based on camera capability"
- Merge "Add tests for network permissions."
- Merge "Add CTS tests for UiccCardInfo"
- Camera ITS: Request focus distance based on camera capability
Following test cases fails on camera devices with minimumFocusDistance
larger than requested focus distance.
-sensor_fusion/test_multi_camera_frame_sync
-sensor_fusion/test_sensor_fusion
Request correct focus distance based on camera capability.
Bug: 129896159
Test: CTS
Change-Id: I71eb7f80fd6c962ccd86f6cbe6872c7aa0ca6dfc
- Update test comments for zic 2019a
Update test comments with knowledge learned from the zic
2019a upgrade.
Bug: 129926912
Bug: 73719425
Test: See system/timezone change
Change-Id: I8073e869ec594e725c5256a447242006066f3652
- Set preferred device in order to trigger routed device changed event.
For MediaPlayer case, the routing callback listener may be added after
the output device is selected. In that case, current test may fail. Set
a device that is different from routed device may cause the routed
device changed.
Test: run RoutingTest
Bug: 129696133
Change-Id: I665fb60ed6d91868702af4b36e045509c6533736
- Add tests for network permissions.
Add two test apps for permission INTERNET and permission
UPDATE_NETWORK_STATS. One app does not have INTERNET permission so it
should not be able to create network socket. The other one specify the
UPDATE_NETWORK_STATS in the AndroidManifest file but it is not a
privileged app so it should not have UPDATE_NETWORK_STATS permission
granted.
Bug: 111560570
Test: CtsNetTestCasesUpdateStatsPermission
CtsNetTestCasesInternetPermission
Change-Id: I107ef938ce9989690f6dd6854719b129a9fdcc60
- Add CTS tests for CallQuality and CallAttributes
Test: atest
Fixes: 129421387
Change-Id: I3c860f502f7548a81e597b42e9332d12012389af
- Add CTS tests for UiccCardInfo
Test: atest
Bug: 129425611
Change-Id: I82565e6def34a6641b9aafab94b8c5c53c441726
* Update dalvik from branch 'simpleperf-release'
to 8ea8a576778615c331a71f85fa8129af31bc8936
- Merge "Snap for 5437783 from 8843541a211b388bd2d48037ea6595265d125730 to simpleperf-release" into simpleperf-release
- Snap for 5437783 from 8843541a211b388bd2d48037ea6595265d125730 to simpleperf-release
Change-Id: I0f328f3ff1f1c1bd892a643243433cbf75cd361c
- Merge "Remove dalvik/libdex"
- Merge "Add sehr, mathieuc to dalvik/OWNERS"
- Add sehr, mathieuc to dalvik/OWNERS
Add a Mountain View owner to dalvik.
Bug: none
Test: none
Change-Id: Ifc89fee2bfbf7c9a12b7138dac04d9d23efc4abc
- Remove dalvik/libdex
Replaced by art/libdexfile and friends.
Bug: 22322814
Test: make checkbuild
Change-Id: I175fd9f3f598ce793d80e8e62c5ac0fa1d2bb7a2
* Update external/ImageMagick from branch 'simpleperf-release'
to 02625eaa5aca8e827b627daf819186254b6529c9
- Snap for 5437783 from 5d4f6bff8c6dfdb28e057b5751d85671c453f729 to simpleperf-release
Change-Id: I78f15f111961edc3c8a031d8dcc8c54b62621d3f
- Upgrade ImageMagick to 'f35547c9abb8a391f99abf2b4f0505fa7ce188bb'
Test: build
Change-Id: Ia16169039644876f5ee64ac67cdf21145397774c
- ...
- ...
- ...
- ...
- https://imagemagick.org/discourse-server/viewtopic.php?f=3&t=35789
- ...
- ...
- ...
- https://imagemagick.org/discourse-server/viewtopic.php?f=2&t=35783
- ...
- ...
- ...
- ...
- Corrected stroke-opacity setting
- ...
- Optimize pixel cache
- ...
- Pixel cache optimization
- https://github.com/ImageMagick/ImageMagick/issues/1526
- ...
- https://github.com/ImageMagick/ImageMagick/issues/1517
- https://github.com/ImageMagick/ImageMagick6/issues/38
- https://github.com/ImageMagick/ImageMagick/issues/1506
- https://github.com/dlemstra/Magick.NET/issues/409
- https://github.com/ImageMagick/ImageMagick/issues/1532
- https://github.com/ImageMagick/ImageMagick/issues/1533
- https://imagemagick.org/discourse-server/viewtopic.php?t=35741
- ...
- Prevent small memory leak
- https://github.com/ImageMagick/ImageMagick/issues/1531
- ...
- https://github.com/ImageMagick/ImageMagick/issues/1528
- Removed invalid typecast.
- Minor refactoring.
- ...
- https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13896
- ...
- https://github.com/ImageMagick/ImageMagick/issues/1526
- https://github.com/ImageMagick/ImageMagick/issues/1506
- https://github.com/ImageMagick/ImageMagick/issues/1506
- https://github.com/ImageMagick/ImageMagick/issues/1515
- https://github.com/ImageMagick/ImageMagick/issues/1518
- https://github.com/ImageMagick/ImageMagick/issues/1517
- https://github.com/ImageMagick/ImageMagick/issues/1519
- https://github.com/ImageMagick/ImageMagick/issues/1520
- https://github.com/ImageMagick/ImageMagick/issues/1522
- https://github.com/ImageMagick/ImageMagick/issues/1525
- Removed incorrect -1.
- Minor refactoring.
- Fixed settings the area that should be decoded.
- The default number of iterations should be 1 instead of zero.
- Added FLV as an alias for the MPEG coder.
- https://github.com/ImageMagick/ImageMagick/issues/1523
- ...
- ...
- ...
- ...
- OTSU thresholding framework
- https://imagemagick.org/discourse-server/viewtopic.php?f=1&t=35650
- ...
- ...
- ...
- https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13694
- ...
- Report exception if opening TIFF did not work out
- https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13664
- ...
- ...
- ...
- ...
- One lock for each resource
- ...
- ...
- ...
- ...
- ...
- ...
- ...
- ...
- ...
- ...
- Initialize primitive structure after resizing
- Clean up compiler warnings
- https://imagemagick.org/discourse-server/viewtopic.php?f=3&t=35591
- Don't default to fast DCT method
- https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13538
- Don't leak file paths for PDB & DPX formats
- ...
- ...
- ...
- ...
* Update external/autotest from branch 'simpleperf-release'
to fed9948f2dd6feb7d716dda69d904c2b456a9355
- Snap for 5437783 from 8e23e2a45fd0e8f31581dcdfadd8a17e34021d5e to simpleperf-release
Change-Id: I5b07b06e70a8569275bf3332e88c0ee21d3e0740
- bluetooth: Add device class for 'peripheral'
am: cd4673df06
Change-Id: Ie48da0d7a2da3538df3a15fc3847868a4bf32ae3
- network_WiFi_UpdateRouter: update Gale test AP version
am: 9b0b6af55d
Change-Id: Ie2939f53231f91b9e7e0b72feacc7d02c1df288b
- security_AltSyscall: unroll sub-test loop
am: 7ee0d0b1a1
Change-Id: Id8396ea75c1e6b6b61f678d693f7bc49d3b4b9e0
- autotest: reduce required inode count for Gale
am: a6e32bf555
Change-Id: Ib830aea9d61ab2cf30f242a09442d665dfd12beb
- Remove Inbox by gmail from cheets_AppCompatTest
am: 7014153a88
Change-Id: Ie2d06f05c927657b61d855cdda9fde00dfb84ac0
- Revert "faft: add firmware_Cr50DeferredECReset into cr50 suites"
am: 6cd4adea4c
Change-Id: I98ba2db86a842c4182e9f05eff7dac6bc1a6c3cb
- bluetooth: Add device class for 'peripheral'
Class of device was defined as None for 'peripheral' which
was causing the test to fail. Use a class of a keyboard
instead.
BUG=chromium:944642
TEST=Tested locally
Change-Id: Ie8201507e3bc6c549ad728e60551ac0d8c5baa22
Reviewed-on: https://chromium-review.googlesource.com/1535157
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Shijin Abraham <shijinabraham@google.com>
Reviewed-by: Shijin Abraham <shijinabraham@google.com>
- network_WiFi_UpdateRouter: update Gale test AP version
Built with:
cros tryjob gale-test-ap-tryjob -g 1525826 -g '*1056670' -g '*1056672' -g '*1056671' --branch release-R74-11895.B
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8918900882286107904
BUG=chromium:941800
TEST=`cros flash` on local image; run through wifi suites; some BT
sanity
Change-Id: I3087e7970ccf2605bf7f1f326bd221d8c0f6517e
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1526244
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>
- security_AltSyscall: unroll sub-test loop
Instead of storing a list of argument tuples and then looping over
it, just call the function directly each time.
BUG=None
TEST=run test
Change-Id: Ib8f1ef11cb83a4770e090f49975ed726366ac86c
Reviewed-on: https://chromium-review.googlesource.com/1549649
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
- autotest: reduce required inode count for Gale
gale-paladin recently started hitting the inode limit on
/mnt/stateful_partition. Reduce it to be inline with
other boards in the Jetstream family.
BUG=b:129795535
TEST=None
Change-Id: I8fb1aab035da067c3e32a6cd4d45429f0cd295c3
Reviewed-on: https://chromium-review.googlesource.com/1549652
Commit-Ready: Laurence Goodby <lgoodby@chromium.org>
Tested-by: Laurence Goodby <lgoodby@chromium.org>
Reviewed-by: Bryce Woodworth <ephax@google.com>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
- Remove Inbox by gmail from cheets_AppCompatTest
Change-Id: I2c8b117f1d8e3ea911a33344cc1cc2927a6fef21
Reviewed-on: https://chromium-review.googlesource.com/1548055
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Meenakshi Thiyagarajan <mthiyagarajan@google.com>
Reviewed-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Meenakshi Thiyagarajan <mthiyagarajan@google.com>
- Revert "faft: add firmware_Cr50DeferredECReset into cr50 suites"
This reverts commit 50232b20ad6116eecba1712e2856d5343a7e90f0.
Reason for revert: This test leaves a dut in cutoff state.
Needs to revert until a fix with cleanup() lands.
Original change's description:
> faft: add firmware_Cr50DeferredECReset into cr50 suites
>
> BUG=none
> BRANCH=none
> TEST=manually ran suite:faft_cr50_prepvt.
> check with servo_v4_with_ccd_cr50 and servo_v4_with_servo_micro.
>
> test_that --board=${BOARD} ${IP} suite:faft_cr50_prepvt
>
> Change-Id: I26bdb919aa30fa3053334a3b00ea76fe4b1d926c
> Signed-off-by: Namyoon Woo <namyoon@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/1533185
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Bug: none
Change-Id: Ifb8842bb2c9cdc1f0651b9e537811e02712cb1a0
Reviewed-on: https://chromium-review.googlesource.com/1549651
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
- cheets_{CTS,GTS}: Explicitly disconnect adb before retrying.
am: 31ffb68b51
Change-Id: Ie537e27ad267cd4dd9f09947a31227223d3afd20
- cheets_{CTS,GTS}: Explicitly disconnect adb before retrying.
When something fell into a bad state, 'adb connect' ends up in
"already connected" error and does not try actual reconnection.
To avoid the case, this CL insert explicit disconnection.
BUG=b:129257938
TEST=some cheets_CTS_N tests.
Change-Id: I94f582cb000902d6a3ec9df0059e1f7b82d40a22
Reviewed-on: https://chromium-review.googlesource.com/1539444
Commit-Ready: Kazuhiro Inaba <kinaba@chromium.org>
Tested-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
* Update external/elfutils from branch 'simpleperf-release'
to 142889466213f7ff20b57dc5ee507d4eb1067a94
- Merge "Snap for 5437783 from 625d86ad23fe686febbf43baee789b2ecca0151a to simpleperf-release" into simpleperf-release
- Snap for 5437783 from 625d86ad23fe686febbf43baee789b2ecca0151a to simpleperf-release
Change-Id: Id272031634d03c7282cc57a8385f093b26880604
- Merge "Upgrade elfutils to 34ff3ca2e86f8a4915500b92a8e00d6f52aa546c"
- Upgrade elfutils to 34ff3ca2e86f8a4915500b92a8e00d6f52aa546c
Test: None
Change-Id: Iadcf303482a84918878f8e90e19d60da0ee60417
- readelf: print_debug_macinfo_section, check cus[0] is not the sentinel.
If there are no CUs at all we can not find any CU DIE file.
https://sourceware.org/bugzilla/show_bug.cgi?id=24398
Signed-off-by: Mark Wielaard <mark@klomp.org>
- libdwfl: Sanity check partial core file phdrs data read.
When reading the phdrs data from the core file check if we got everything,
or just part of the data.
https://sourceware.org/bugzilla/show_bug.cgi?id=24387
Signed-off-by: Mark Wielaard <mark@klomp.org>
- strip: Files with symbols referring to non-existing sections are illformed
The check added in commit 4540ea98c "strip: Fix check test for SHN_XINDEX
symbol" was not complete. The (extended) section index should also exist.
If it doesn't exist, mark the file as illformed.
https://sourceware.org/bugzilla/show_bug.cgi?id=24385
Signed-off-by: Mark Wielaard <mark@klomp.org>
- libelf: Use posix_memalign instead of aligned_alloc.
Older glibc might not have aligned_alloc (it is C11).
Use posix_memalign instead. posix_memalign requires the alignment to
be a multiple of sizeof (void *). So use malloc for smaller alignments.
Signed-off-by: Mark Wielaard <mark@klomp.org>
- libasm: Check return value of gelf_update_ehdr in asm_end.
In theory the gelf_update_ehdr call could fail. Immediately report an
error in that case.
Signed-off-by: Mark Wielaard <mark@klomp.org>
- libelf: Fix possible resource leak in elf[32|64]_updatefile.
When we cannot allocate enough memory to convert the data in
updatemmap we should free the scns before returning an error.
Signed-off-by: Mark Wielaard <mark@klomp.org>
* Update external/flatbuffers from branch 'simpleperf-release'
to 3ae221642d41399a43ea321af40264dadfb54244
- Snap for 5437783 from 6b23ef32f8ae912762a7bdc8dc1f30b8d25e7eeb to simpleperf-release
Change-Id: I99885040602363fc420f9d6360d4cd2cd81be6df
- Upgrade flatbuffers to b2ce86ef8aef9a9caa8bcc99e54591b92d7b2426
Test: build
Change-Id: If01d786a479d0f2f186fb0e1f98d0fe84c390202
- Add compile-time checking of numerical limits in C++ code. (#5270)
* Add checking of numerical_limits<T> in C++ code.
* Add integer suffixes (LL/ULL) to int64 values in the IntegerBoundaryTest
- Update grammar to reflect required type signature for enum declarations. (#5269)
- Add missing test data file to BUILD file (#5264)
$ cat
/home/austin/.cache/bazel/_bazel_austin/4b3182bfa237d7e256d9f18ffe58322f/execroot/com_github_google_flatbuffers/bazel-out/k8-opt/testlogs/flatbuffers_test/test.log
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //:flatbuffers_test
-----------------------------------------------------------------------------
VALUE: "0"
EXPECTED: "1"
TEST FAILED: tests/test.cpp:2029, flatbuffers::LoadFile( (test_data_path
+ "union_vector/union_vector.json").c_str(), false, &jsonfile) in
VALUE: "0"
EXPECTED: "1"
TEST FAILED: tests/test.cpp:2100, parser.Parse(jsonfile.c_str()) in
VALUE: "0"
EXPECTED: "1"
TEST FAILED: tests/test.cpp:2103, VerifyMovieBuffer(jverifier) in
- Bazel CI: fix bad value in yml (#5262)
Use the "simple format" defined here:
https://github.com/bazelbuild/continuous-integration/blob/69cf7ec23d984dcbb41fffe946e07ebf5ab7e0f1/buildkite/bazelci.py#L1453
This will unbreak the "Bazel / FlatBuffers"
pipeline on Bazel CI, see
https://buildkite.com/bazel/flatbuffers
- Fix a warning on compiling with clang (#5258)
- Add inequality operator (inspired from #263) (#5257)
- [C++] Changes in the flathash program (#5255)
* Correct the usage in the flathash program
As it is possible to have -- before the occurrence of the first
input STRING.
* Exit with 1 in the flathash program when an error occurs
- Fixed tutorial markdown file (#5248)
Path specified in tutorial file was pointing to invalid location.
- Further fixes to make minireflect compatible with old behavior.
Change-Id: I92c257ec4ab4a0cf4676bd98523b766ce25bf4f6
- Unify line ending rules in '.editorconfig' and '.gitattributes' (#5231)
* Unify line ending rules in '.editorconfig' and '.gitattributes'
* Revert '.gitattributes'
- fix invalid comments in the check-source.py
- Fixed vector_delimited excluding delimiter
Change-Id: I3e758d44b9845d6df91332bb609b4b7ad88659ac
- Fixed shadowing warning in older gcc for vector_delimited
Change-Id: Ia4d56a5eb086f86eb5d1ad6ddae64e4a51bf3aa3
- Made ToStringVisitor backwards compatible with older behavior.
This to support code that relied on tables being multiline,
but not vectors.
This behavior was changed in:
https://github.com/google/flatbuffers/commit/b1a925dfc2ac78508aee89029e950057405f0a0a#diff-c45c8fbffbc64f7ff4aa2978612b10d8
Change-Id: I4c95471b643b2b3fab95e06b1294e19d686b492c
- Made JS enum declarations compatible with google closure
Original change by: https://github.com/alexames
Change-Id: Ib65bd02156d1c3637ed278a8334a2307caacaa44
- Disabled constexpr for hashing functions.
This was incompatible with -Wc++98-c++11-compat on some platforms,
due to local variables in the function.
Change-Id: Idef510c2cefe944eef2e0656f5a219c2158063e6
- Narrows template ascii routines to prevent a possible signed overflow in generic code. (#5232)
- Fix typo in dart documentation (#5230)
- [C++] Object API: document custom string type requirements,
implement better custom string type constructor alternative
for Unpack() and fix bug with vector of custom string types
in Pack().
Squashed commit of the following:
commit e9519c647ef949b22756ed660839dd3af854881c
Author: Luca Longinotti <luca.longinotti@inivation.com>
Date: Tue Mar 5 18:24:49 2019 +0100
tests: regenerate code, reverts change to CreateVectorOfStrings().
commit 117e3b0679209f2aa55cbee18c4036e7da4bd4b3
Author: Luca Longinotti <luca.longinotti@inivation.com>
Date: Tue Mar 5 18:15:05 2019 +0100
idl_gen_cpp.cpp: move clang-format on/off outside of declaration, so they are kept properly aligned automatically.
commit 4791923806965637d5b13f7003329bfbb2fdf18b
Author: Luca Longinotti <luca.longinotti@inivation.com>
Date: Tue Mar 5 18:11:40 2019 +0100
idl_gen_cpp.cpp: full clang-format run with provided Google format file, enforce 80 lines width.
commit 2f0402f9ff43b1af0a29806932e08e6d64373345
Author: Luca Longinotti <luca.longinotti@inivation.com>
Date: Tue Mar 5 18:09:32 2019 +0100
CppUsage: address requested changes.
idl_gen_cpp.cpp: fix formatting, keep CreateVectorOfStrings for normal string cases.
commit 371d4e0b7972a59e5cff418c44e4043c016ce56a
Author: Luca Longinotti <luca.longinotti@inivation.com>
Date: Fri Mar 1 16:35:29 2019 +0100
Fix compile error with a vector of non-std::strings. CreateVectorOfStrings() expects a vector of std::string types, but that's not always the case.
commit 92b90d7f0fbcfc837a94aa06bedccec0f7b4bb62
Author: Luca Longinotti <luca.longinotti@inivation.com>
Date: Fri Mar 1 16:15:36 2019 +0100
Document requirement for custom string types to implement empty() and be constructible from std::string.
Add new option --cpp-str-flex-ctor to construct custom string types not via std::string, but (char * + length).
commit 28cb2e92d5b7684b5df5184da3a3fad2d0cda733
Author: Luca Longinotti <luca.longinotti@inivation.com>
Date: Fri Mar 1 14:31:17 2019 +0100
idl_gen_cpp.cpp: clang-format run, to better separate changes in content from formatting.
Change-Id: I4887ba2f2c632b9e7a8c938659b088cd95690870
- [Rust] Don't use inner attributes for `allow` (#5212)
* Don't use inner attributes for `allow`
Messes with being able to easily include elsewhere
* Regenerate tests
* No-op to retrigger CI
* Add the rest of the `allow` attributes
- Small usability tweaks to the rust codegen. (#5213)
- Fix rust crate for big-endian targets (#5229)
Thanks for tackling this, @tymcauley !
* big endian docker test -- wip
* tweaks
* tweaks
* tweaks
* docker tweaks
* fix conditional compilation issues
* reactivate other docker tests
* try some more cross-platform config (from tymcauley)
* Update tests/docker/languages/Dockerfile.testing.rust.big_endian.1_30_1
Co-Authored-By: rw <rw@users.noreply.github.com>
* Update tests/docker/languages/Dockerfile.testing.rust.big_endian.1_30_1
Co-Authored-By: rw <rw@users.noreply.github.com>
* Update tests/docker/languages/Dockerfile.testing.rust.big_endian.1_30_1
Co-Authored-By: rw <rw@users.noreply.github.com>
* Resolved Rust warnings during big-endian builds.
* Unify Rust test suites for x86 and MIPS builds.
Note that I had to add four extra packages to the MIPS `Dockerfile`:
`libexpat1`, `libmagic1`, `libmpdec2`, and `libreadline7`. For a reason
I couldn't identify, even the simplest Rust MIPS binaries run with
`qemu-mips` would fail with a segfault when run through this
`Dockerfile`. After installing the `gdb-multiarch` package to attempt to
debug the issue, the binaries ran successfully. I pared down the
packages installed by `gdb-multiarch`, and these four packages are the
minimum subset necessary to get Rust MIPS binaries running under
`qemu-mips`.
* Changed Rust tests to use `Vector`s instead of direct-slice-access.
The direct-slice-access method is not available on big-endian targets,
but `flatbuffers::Vector`s provide an array interface that is available
on all platforms.
* Resolved FooStruct endianness issues using explicit struct constructor.
This more closely resembles how FlatBuffers structs are constructed in
generated Rust code.
* Added explanation of how `FooStruct` parallels generated struct code.
Also collected duplicate implementations of `FooStruct` into a common
location.
- Removed -Wc++98-compat-extra-semi for compatibility with older clang.
Change-Id: I6dfadb5289a4396ad2f3d16baf1bdb99c7534174
- Bazel ci (#5228)
* Stop building for Windows until the build passes
ERROR: D:/b/bk-windows-java8-bd0z/bazel/flatbuffers/BUILD:123:1: Couldn't build file _objs/flatbuffers_test/test.obj: undeclared inclusion(s) in rule '//:flatbuffers_test':
this rule is missing dependency declarations for the following files included by 'tests/test.cpp':
'tests/monster_test_generated.h'
'tests/monster_extra_generated.h'
The files in tests are being found instead of the generated files since
Windows doesn't have any sandboxing. For now, let's disable the rules
and come back to it.
* Fix buildifier warnings
Clean up docstrings and add a module docstring.
- Fixed vector of union JSON parsing.
This for some reason never had a test case, and was broken.
Change-Id: If832f5eb8b6c5ba8a75257464892634b38719c55
- [Rust] Fixed codegen documentation for Tables (#5227)
- [Go] Add mutation functions for vector elements (#5221)
Fixes #5206
* Update external/one-true-awk from branch 'simpleperf-release'
to 10685364c011cd9e31e8de56cb33f0bedf6faa9d
- Snap for 5437783 from e02f00ab34bb254040e6082f82b3f77109a6b8d3 to simpleperf-release
Change-Id: I10a7f86f80f0ddc03c34729297bdbad170f5866e
- Upgrade one-true-awk to 55edb1b1ddaf56e18f8256f9872080bf713d895b
Test: None
Change-Id: I1780f3afba5cef8e91935ae6fd1fc7fd89c35579
- Simplify cross-compiling change. Update FIXES.
- Fix cross-build (#34)
* Fix cross-build
Fixes in make file to support cross-build because maketab is a host tool and should be compiled with host compiler
* some
- Sync FIXES with GitHub repo activity.
- Merge pull request #30 from McDutchie/interval-expr
backport ERE interval/repetition expressions from Apple awk-24
- Merge remote-tracking branch 'upstream/master' into interval-expr
main.c: bump version to 20190305
- repeat(): add FATAL calls for errors that should be impossible
- backport ERE interval/repetition expressions from Apple awk-24
The lack of POSIX interval expressions[*] (a.k.a. bounds, a.k.a.
repetition expressions) in regular expressions is listed under BUGS
in 'awk.1'. Apple's version of onetrueawk has supported these since
at least 2009, judging by the date stamp on their src/b.c in:
https://opensource.apple.com/tarballs/awk/awk-24.tar.gz
A bug report prompted NetBSD to swiftly integrate this code into
their awk. This commit is based on that NetBSD diff.
http://gnats.netbsd.org/53885
https://github.com/NetBSD/src/commit/f3e4c4ca1dfcdd939a2e33ebfe708f01e25b3bae
b.c:
- Backport POSIX-standard interval expressions support in regular
expressions via NetBSD from Apple awk-24 (20070501).
main.c:
- Bump version ID.
FIXES:
- Add note and credit for this feature.
awk.1: section BUGS:
- Remove line saying interval expressions are not supported.
_________
[*] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html#tag_09_04_06
* Update external/perfetto from branch 'simpleperf-release'
to e2604d51b385cd5327443212685c487216cf23f5
- Snap for 5437783 from 3c836b671503ce665ee4a9e4fe79e8758866acfc to simpleperf-release
Change-Id: I6d79b08e8d61744caa749b37e31a67eb4b64816a
- Merge "--help takes no argument."
- Merge "Add total unwinding time to stats."
- --help takes no argument.
Change-Id: Iaeb2eb0e478be7402693557f961bf561d46c9ec8
- Add total unwinding time to stats.
Bug: 129054982
Change-Id: I644f06c28c79ffe4c16f672a6c604592bdd2381e
- Merge "perfetto-ui: Change counter quantization to use max"
- perfetto-ui: Change counter quantization to use max
Change-Id: I512af6c4da4a05e369ab0d34a689eefb3d036219
* Update external/selinux from branch 'simpleperf-release'
to 22861dbde728c27ed85b1619f1a8b1ee73786a36
- Snap for 5437783 from 3e334d0162fa79f0d650ed777fd749f4fe7adc04 to simpleperf-release
Change-Id: Idb3171615dda6041b85f9bcac550c371d52b1ace
- export seapp_context_init
Bug: 129704390
Test: ps -AZ; verify that apps have correct context
Test: with "#define DEBUG 1" to verify that
selinux_android_seapp_context_reload() is only called once
in zygote.
Change-Id: I8120f66ce77b472d9190647e13f6da6c6f52464a
(cherry picked from commit 5a26d140d6a7874fc6bab8e39a16a17e0d8b8e58)
* Update frameworks/base from branch 'simpleperf-release'
to 7dd7b8f8fb10fb3374916308415266b1670bc847
- Merge "Snap for 5437783 from 37f662002956ba0cf7a86ccba543611e31a16b14 to simpleperf-release" into simpleperf-release
- Snap for 5437783 from 37f662002956ba0cf7a86ccba543611e31a16b14 to simpleperf-release
Change-Id: I3d2d2b71b871ce7aa371be3ee58a49d961580c38
- Merge "Remove call identification APIs."
- Merge "Convert core/tests/**/Android.mk file to Android.bp"
- Merge "Add @hide API to get the phone account handle for a subId."
- Add @hide API to get the phone account handle for a subId.
This is used in SubscriptionManager to figure out which phone account
is being updated when the default voice sub changes. It seemed like
a good spot to put it since we should really have an api for this in
the future.
Test: Manual, manual, manual
Bug: 128916238
Change-Id: If5137c0e7f01a14810e0ee94e5d857d69f368a87
- Remove call identification APIs.
Removing the CallIdentification API surface.
Test: Build, run tests.
Bug: 129531123
Change-Id: I5f1451ffba04ee438df739a17472c028c44f19b2
Merged-In: I5f1451ffba04ee438df739a17472c028c44f19b2
- Convert core/tests/**/Android.mk file to Android.bp
See build/soong/README.md for more information.
Bug: 122332340
Test: treehugger
Change-Id: I368327d0f3b4bd3068e10c8750ece45e227531cf
* Update frameworks/ml from branch 'simpleperf-release'
to ec80db289c3149069296334d2c57205cb0f1ee7d
- Merge "Snap for 5437783 from e4b74f764624ac10146fb2302d68e85714e9f69c to simpleperf-release" into simpleperf-release
- Snap for 5437783 from e4b74f764624ac10146fb2302d68e85714e9f69c to simpleperf-release
Change-Id: Ia0cedab12beefb7d62b63c58e8b04b809dc68666
- Merge "Allow running a subset of NeuralNetworksTest_static passes."
- Allow running a subset of NeuralNetworksTest_static passes.
NeuralNetworksTest_static runs the entire test suite 7 times
with various knob settings (e.g., whether accelerators are
used, or only cpu). Each of these 7 runs is a "pass".
This CL adds the ability to run a subset of passes: Supply
an additional argument that is a bitmask indicating which
passes to run. To see which passes are available, pass 0.
We also now check to see that there are no unexpected
arguments.
Bug: 122350458
Test: NeuralNetworksTest_static and various values for the extra argument
For example:
$ adb shell NeuralNetworksTest_static --gtest_filter=GeneratedTests.add 0
[**********] useCpuOnly = 0, computeMode = ComputeMode::ASYNC, allowSyncExecHal = 1 // pass 10
SKIPPED PASS
[**********] useCpuOnly = 0, computeMode = ComputeMode::SYNC, allowSyncExecHal = 1 // pass 8
SKIPPED PASS
[**********] useCpuOnly = 1, computeMode = ComputeMode::ASYNC, allowSyncExecHal = 1 // pass 11
SKIPPED PASS
[**********] useCpuOnly = 1, computeMode = ComputeMode::SYNC, allowSyncExecHal = 1 // pass 9
SKIPPED PASS
[**********] useCpuOnly = 0, computeMode = ComputeMode::ASYNC, allowSyncExecHal = 0 // pass 2
SKIPPED PASS
[**********] useCpuOnly = 0, computeMode = ComputeMode::SYNC, allowSyncExecHal = 0 // pass 0
SKIPPED PASS
[**********] useCpuOnly = 0, computeMode = ComputeMode::BURST, allowSyncExecHal = 1 // pass 12
SKIPPED PASS
$ adb shell NeuralNetworksTest_static --gtest_filter=GeneratedTests.add 4100
[**********] useCpuOnly = 0, computeMode = ComputeMode::ASYNC, allowSyncExecHal = 1 // pass 10
SKIPPED PASS
[**********] useCpuOnly = 0, computeMode = ComputeMode::SYNC, allowSyncExecHal = 1 // pass 8
SKIPPED PASS
[**********] useCpuOnly = 1, computeMode = ComputeMode::ASYNC, allowSyncExecHal = 1 // pass 11
SKIPPED PASS
[**********] useCpuOnly = 1, computeMode = ComputeMode::SYNC, allowSyncExecHal = 1 // pass 9
SKIPPED PASS
[**********] useCpuOnly = 0, computeMode = ComputeMode::ASYNC, allowSyncExecHal = 0 // pass 2
Note: Google Test filter = GeneratedTests.add
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from GeneratedTests
[ RUN ] GeneratedTests.add
[ OK ] GeneratedTests.add (71 ms)
[----------] 1 test from GeneratedTests (72 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (74 ms total)
[ PASSED ] 1 test.
[**********] useCpuOnly = 0, computeMode = ComputeMode::SYNC, allowSyncExecHal = 0 // pass 0
SKIPPED PASS
[**********] useCpuOnly = 0, computeMode = ComputeMode::BURST, allowSyncExecHal = 1 // pass 12
Note: Google Test filter = GeneratedTests.add
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from GeneratedTests
[ RUN ] GeneratedTests.add
[ OK ] GeneratedTests.add (24 ms)
[----------] 1 test from GeneratedTests (27 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (29 ms total)
[ PASSED ] 1 test.
Change-Id: I198d7d6b3190b6d77d343c6beabf7093b0d18051
Merged-In: I198d7d6b3190b6d77d343c6beabf7093b0d18051
(cherry picked from commit 9f71a04d782d4f08ab8aea3b095131753772fb0d)
* Update frameworks/opt/telephony from branch 'simpleperf-release'
to c21e697a89c72093f99540f78c3083316ccae2ac
- Merge "Snap for 5437783 from e42cff04f36e10571a167bf168ee6abee556b56b to simpleperf-release" into simpleperf-release
- Snap for 5437783 from e42cff04f36e10571a167bf168ee6abee556b56b to simpleperf-release
Change-Id: Ia91cf71edb2e8b9871eaf462087ece1027742608
- Merge "add PHONE_ID extra field for INTENT_ISIM_REFRESH"
- Merge "Handle exception in getSimStateForSlotIndex."
- Merge "Ensure Telecom user selected phone account changes with default voice sub."
- Handle exception in getSimStateForSlotIndex.
An IllegalStateException is possible but it should not be propogated
to the remote caller.
Test: basic sanity
Bug: 128939123
Change-Id: I5f75e79fb0ce57176a805b92aa57c0f021ea0197
- Ensure Telecom user selected phone account changes with default voice sub.
When the default voice sub is changed in SubscriptionManager, ensure that
the corresponding setting in Telecom is also changed.
Test: Manual
Bug: 128916238
Change-Id: I5a32a87d0ad79d0383642a3e5b0ff9380b9f9b33
- add PHONE_ID extra field for INTENT_ISIM_REFRESH
phoneid information is needed because receiver should
know which phone is refreshed.
Test: builds
Change-Id: I1b14a431038c8ca09da4e2e8da62389070f2da16
Signed-off-by: Sanghee Kim <haya93@samsung.com>
* Update libcore from branch 'simpleperf-release'
to 6a0742e6aa3fe5709b28eb15344a8ef723a15912
- Merge "Snap for 5437783 from 1bf3b35f1fce3d4c4ed912c3dbb023bd456f4e3b to simpleperf-release" into simpleperf-release
- Snap for 5437783 from 1bf3b35f1fce3d4c4ed912c3dbb023bd456f4e3b to simpleperf-release
Change-Id: I4fbc1360505e84c41ae74fb370131d82897439f8
- Merge "Tidy up unused code / unnecessary logic"
- Merge "Fix Date.toString() behavior / tidy up comments"
- Fix Date.toString() behavior / tidy up comments
Fix Date behavior / tidy up TimeZone comments and tests.
This commit contains a mix of documentation, test and non-test changes
to address issues found when testing the use of zic 2019a for producing
Android's tzdata file.
Comments marked with http://b/73719425 can be removed once we can be
sure of the version of zic Android uses (in a later release).
Bug: 73719425
Bug: 129926912
Test: CTS: run cts-dev -m CtsLibcoreTestCases
Change-Id: I3378660c83874a642280db9b9dd5a49adee13a15
- Tidy up unused code / unnecessary logic
The hostnameVerifier field is bypassed in Android's HttpsURLConnectionImpl
so it shouldn't hurt to set it on creation (even though unused).
The HostnameVerifier impl class is no longer used.
Test: CTS: CtsLibcoreTestCases
Test: CTS: CtsLibcoreOkHttpTestCases
Change-Id: I770cf98359387430ef493bdffcce0b2c992f3b75
* Update packages/apps/Settings from branch 'simpleperf-release'
to 2d951f6c63908568ed87734c4f5fcf306a9e364b
- Merge "Snap for 5437783 from a85fa6c51def6e1a1828a235757064eee78e7532 to simpleperf-release" into simpleperf-release
- Snap for 5437783 from a85fa6c51def6e1a1828a235757064eee78e7532 to simpleperf-release
Change-Id: I5f65a44fae18618ff978f7f320e517cbe009a7ff
- Merge "Make RadioInfo settings menu work for mSIM"
- Merge "Show the disclaimer for WFC emergency call limitation"
- Make RadioInfo settings menu work for mSIM
Just add a spinner to the top of the screen which lets you select the
phoneIndex. Upating this value updates the mTelephonyManager
mImsManager, and mPhoneStateListener to use the selected phoneIndex and
the subscription associated with it.
Also adds fields for current subId and default data sim subId.
Test: manual test
Fixes: 128033739
Change-Id: Id075e3bffe20523d8ceeb8f2e4320f995abdab55
Merged-In: Id075e3bffe20523d8ceeb8f2e4320f995abdab55
- Show the disclaimer for WFC emergency call limitation
The emergency calls might not work properly via wifi calling, especially
in areas with no 2G/3G coverage. Display the disclaimer for the this
limitation when a user enabled the wifi calling setting.
Test: manual - Checked that the disclaimer for emergency call limitation
is shown when changing wifi calling setting to turned on.
Test: auto - Passed EmergencyCallLimitationDisclaimerTest.
Bug: 68115846
Change-Id: I881d479c1e02525ac614c66594637a5e0347d70c
Merged-In: I881d479c1e02525ac614c66594637a5e0347d70c
* Update packages/providers/CallLogProvider from branch 'simpleperf-release'
to cb66c88edfdce7a512efde9ae0fec1196acae432
- Snap for 5437783 from 5a53a75ab4266f99b747fc0fde67539797233d1f to simpleperf-release
Change-Id: Ib826d9c1b09635297679e702aa5da0c6296765c9
- Remove call identification APIs.
Removing the CallIdentification API surface.
Test: Build, run tests.
Bug: 129531123
Change-Id: I78d09939c17c5d50dd949c2c1abb9efc2594ded2
Merged-In: I78d09939c17c5d50dd949c2c1abb9efc2594ded2
* Update packages/providers/ContactsProvider from branch 'simpleperf-release'
to 695a7f08b6560353d59fc1f38878585e7bbffe65
- Merge "Snap for 5437783 from 397c5f1f388c4fe829ef73d64de1f536e3458a30 to simpleperf-release" into simpleperf-release
- Snap for 5437783 from 397c5f1f388c4fe829ef73d64de1f536e3458a30 to simpleperf-release
Change-Id: I90fe7bd0df3090ffa1bd45f47e9c62dbce200908
- Merge "Remove call identification APIs."
- Remove call identification APIs.
Removing the CallIdentification API surface.
Test: Build, run tests.
Bug: 129531123
Change-Id: I9cba511e7763e7928e05c9f1af95badef3b88c56
* Update packages/services/Telecomm from branch 'simpleperf-release'
to cf7c9147380c385846fe75d3ed9fc7c65bfb21fd
- Snap for 5437783 from 49b3bc6f88442f6c0b166a433d1020d023cb0a11 to simpleperf-release
Change-Id: I52dc98423294619001502b42fe81eba3f824e0eb
- Merge "Tweaks to the call blocking options."
- Merge "Clean role manager adapter comment"
- Clean role manager adapter comment
Bug: 129778256
Change-Id: Id82c080e032a6bebc335cf7f258518b3a5a45f0d
Test: Build
- Merge "Remove call identification APIs."
- Merge "Update code to refresh the default voice sub from Telecom."
- Update code to refresh the default voice sub from Telecom.
Ensure the change is only applied when there actually is a change to be
made. Also ensure that setting the default to "ask every time" is
propagated as well.
Test: Manual
Bug: 128916238
Change-Id: Ic4995808ddd393a89f1340bdf84ad2b0a4904d6d
- Remove call identification APIs.
Removing the CallIdentification API surface.
Test: Build, run tests.
Bug: 129531123
Change-Id: I80cbe7a86531366e2fa2b8d5497a8865afff5782
Merged-In: I80cbe7a86531366e2fa2b8d5497a8865afff5782
- Tweaks to the call blocking options.
1. Add option for device to hide the "block callers not in contacts" option;
there was a large potential for the user to accidentally block too many
calls. The dialer app would need to do some work to ensure it makes the
user aware of the fact that they're blocking large numbers of calls.
Since this is not mandatory per the CDD requirements, making this a
configurable option. This way a device can choose to use this feature and
provide a good user experience around exposing the blocked calls.
2. Add an option for a device to combine the block options for "restricted" and
"unknown" callers options. Conceptually most users won't recognize the
difference between the two types of calls, so it makes sense to combine
them in a generic sense unless there is a strong desire for a device to
support separating these options.
Test: Manual; verified that "not in contacts" option is hidden.
Test: Manual; verified that toggling the option to combine the unknown
and restricted options updates the shared prefs for both.
Fixes: 129353233
Change-Id: I85694512cd71e8296f270d18b0086458dd863e56
* Update packages/services/Telephony from branch 'simpleperf-release'
to d30261f9faf5c2e7c3c53babe8cd15940c132577
- Merge "Snap for 5437783 from 46329f27deaf72089ffdb498ad66a7d6e7dfb3b1 to simpleperf-release" into simpleperf-release
- Snap for 5437783 from 46329f27deaf72089ffdb498ad66a7d6e7dfb3b1 to simpleperf-release
Change-Id: I48ee1491ef36ae54317ed4b48320083fd396db44
- Merge "Implementation for getPhoneAccountHandleForSubscriptionId method."
- Implementation for getPhoneAccountHandleForSubscriptionId method.
Test: Manual
Bug: 128916238
Change-Id: If3e6a217168d8e49128d41a74ea316d774e5ec02
* Update system/core from branch 'simpleperf-release'
to effe82b8bed58ddaa3e64c29584bc44c6abff865
- Merge "Snap for 5437783 from 5c58e092f3df0e70235a4cdd41790a505e1ee596 to simpleperf-release" into simpleperf-release
- Snap for 5437783 from 5c58e092f3df0e70235a4cdd41790a505e1ee596 to simpleperf-release
Change-Id: I06e3596a55d13b78ca8cdb553845e31997448caa
- Merge "adb: defuse CHECK on IOVector::append of an empty block."
- Merge "Remove `r` in R."
- Merge "Avoid leaking property values into logs on error"
- Remove `r` in R.
Obsoleted by toybox `devmem` instead.
Test: builds
Change-Id: I35c1ed2cfa9b3073cab405cfaf3c989fb2a72aa2
- Merge "CgroupSetupCgroups: don't leak fd."
- Avoid leaking property values into logs on error
The purpose of having fine grain read/write control over the property
space is to help ensure the confidentiality of data stored in
properties. Leaking property values into the dmesg buffer on errors
exposes the value outside of the access control rules specified by
policy.
(arguably this is also true for the property name, not just the value.
However, property names are exposed in other places now, so the
incentive to fix this is lower. It would also take away a valuable
debugging tool.)
Test: compiles
Change-Id: I4a0634b8b5e4fd2edf718eaf7343940df627366d
- adb: defuse CHECK on IOVector::append of an empty block.
Bug: http://b/129706741
Test: treehugger
Change-Id: I35a35d20d179a155adb4fe83078739fcaf517136
- CgroupSetupCgroups: don't leak fd.
- If file is unlinked, the mmapped region is still there.
- If file is truncated, a SIGBUS will be seen, and holding
the fd doesn't help.
Test: boots (sanity)
Bug: 123664216
Change-Id: I6683804bc795fab6798891a4471e5fe58fbffe13
* Update system/libhwbinder from branch 'simpleperf-release'
to 9846632cba4c023383e11d85ecce35f73b69306c
- Snap for 5437783 from 2fbdf84f2ac221d6b1a2d1feecc487993a155ab7 to simpleperf-release
Change-Id: Id7fb89f784ce43b661fedd97b6174e1e32540c4e
- binder: print the bad cmd error to android log
https://code.google.com/p/android/issues/detail?id=226068
Signed-off-by: liangweikang <liangweikang900911@gmail.com>
(cherry picked from commit a43ee156098776698a39882bb00ecebc555948d0)
Bug: 129785390
Test: N/A
Change-Id: I79d57ac2d3b3eb5f4ff7c4ff7a18265b6b9292a1
- Restore to libbinder style setTheContextObject.
libhwbinder made the_context_object a member of IPCThreadState.
Reverting here for two reasons:
- reduce libbinder/libhwbinder delta
- this breaks multi-threaded context service managers
Bug: 129785390
Test: (sanity) boot
Change-Id: I0be4cacffb5a207ebbc9724ffb92c1c7d9de3a2f
* Update system/sepolicy from branch 'simpleperf-release'
to 6ddf8f5de1dc76938f899f5da06be88cdb6c96c5
- Snap for 5437783 from 16a9ab81e1f19ee70f9e748268f0d7687c5cc94a to simpleperf-release
Change-Id: I73a76b7caf8872b6182bd29e75986c5a95bbac2c
- Merge "Allow surfaceflinger to access bufferhub"
- Merge "system_server_startup: allow SIGCHLD to zygote"
- system_server_startup: allow SIGCHLD to zygote
avc: denied { sigchld } for comm="main"
scontext=u:r:system_server_startup:s0 tcontext=u:r:zygote:s0
tclass=process permissive=0
Test: build
Change-Id: I98c106b17ba1740f953c3108bd0fc927c150096f
- Allow surfaceflinger to access bufferhub
Bug: 112940221
Test: AHardwareBufferTest
Change-Id: I3e0304d8e8e3a91860ea8ce4ebe740966beed301
* Update system/vold from branch 'simpleperf-release'
to 1dea90c1c9c6ceab0a5d7a4c0d9056ba986e576b
- Merge "Snap for 5437783 from b8d17384c5f8613dc9348d95cc06f6a44eeb59e2 to simpleperf-release" into simpleperf-release
- Snap for 5437783 from b8d17384c5f8613dc9348d95cc06f6a44eeb59e2 to simpleperf-release
Change-Id: I945b650daeca5544e3e7cd324ca923c37f0fac94
- Merge "vdc: print the failed command with failure status."
- vdc: print the failed command with failure status.
vdc currently only prints generic binder failure status on failure.
This doesn't help debugging early boot failures at all since we don't
know which exact vdc command failed. Fix that by adding the command as
part of the failure message.
Bug: 129946805
Test: Boot cuttlefish
Change-Id: Ic2367cf592d6b5bf23d6d4b1447baa1baf41afe7
Signed-off-by: Sandeep Patil <sspatil@google.com>
* Update test/suite_harness from branch 'simpleperf-release'
to 786d8f9ba79cf20c86a06c69ab8ad451d44318cc
- Snap for 5437783 from 88eb1a067d7c70458bd004b83c5e6ff8f021193a to simpleperf-release
Change-Id: I921916fdc291715f5ede89694f10ebde7ab4ba63
- Merge "add flaky test to known failure list"
- add flaky test to known failure list
Bug: 129859594
Test: atest CtsAtomicInstallTestCases
Merged-In: Ib3e749bec95626e123cd56d0f203b1fda5b7429f
Change-Id: Ib3e749bec95626e123cd56d0f203b1fda5b7429f
* Update tools/apksig from branch 'simpleperf-release'
to 711e693646bc21d2d903cd2397136a875576edf0
- Snap for 5437783 from ad82f37021a0b66d57f52746fc1ac34c809ba534 to simpleperf-release
Change-Id: Ic8471c2cc1f0cd8a9ccd859f2c174349efc56a26
- Reencode negative modulus in APK signing block to allow app updates
The V2 and V3 signature schemes verify the public key from the signature block
against the public key in the certificate that acts as the signature / identity for the
app. If the certificate is incorrectly encoded with a negative modulus (the modulus
has a leading 1 in the encoding without a preceding zero byte to encode the integer
as positive), then the V2 / V3 signature verification will fail as the public key will be
reencoded with a positive modulus which will not match the key in the signature block.
This change adds support for this improper encoding by reencoding the modulus for
the public key that is written in the signature block to ensure the public key verification
is successful on device.
Bug: 80184678
Test: Manually verified a certificate with a negative modulus could be used to sign and
install APKs with the V2 and V3 signature schemes.
Change-Id: I24df8e30ed52a8034e75bd8f72cbd76209bb0db7
* Update tools/test/connectivity from branch 'simpleperf-release'
to fc89e191f520ce1831a986a12c0b5937d52c5507
- Snap for 5437783 from 2a9416c67fd32d32b37c14383e6be13977c31b47 to simpleperf-release
Change-Id: I9bdc964729d1f8b0275e35d4f585b2f985043ebc
- Remove obsolete logger arg passed into MG3710A objects
Analogous to aosp/939625
Bug: 129488648
Test: None
Change-Id: Ic82ef557e4f8b91b24cfcb33432a919607cef372
- Remove obsolete logger arg passed into MD8475A objects
The logger for MD8475A is never set to be any logger other than the root logger. Remove this parameter from the MD8475A controller constructor.
Bug: 129488648
Test: None
Change-Id: Ic9e9353bf615d691b76ac25de00d103a33475eef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Description
memory leaks in AcquireMagickMemory
Steps to Reproduce
./magick composite input1 input2 output.aai
System Configuration
1、Linux ubuntu 4.15.0-42-generic #45~16.04.1-Ubuntu SMP Mon Nov 19 13:02:27 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
2、./configure CC="gcc" CXX="g++" CFLAGS="-g -fsanitize=address"
memory_leaks.zip
credit:
ADlab of venustech
The text was updated successfully, but these errors were encountered: