Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create plant constants for global lignin and CN and CP ratios #748

Open
davidorme opened this issue Feb 18, 2025 · 0 comments
Open

Create plant constants for global lignin and CN and CP ratios #748

davidorme opened this issue Feb 18, 2025 · 0 comments

Comments

@davidorme
Copy link
Collaborator

davidorme commented Feb 18, 2025

We need to move many of the values in calculate_turnover into PlantConstants, so that they are not hard-coded. Ultimately these may move into Plant Functional Traits, but we need to align that change with pyrealm.

We need to add the following constants for ..._lignin , ..._c_n_ratio and ..._c_p_ratio

  • "stem_lignin" (replacing "deadwood_lignin")
  • "senesced_leaf_lignin" (replacing "leaf_turnover_lignin")
  • "leaf_lignin" (a new addition)
  • "plant_reproductive_tissue_lignin" (replacing "plant_reproductive_tissue_turnover_lignin")
  • "root_lignin" (replacing "root_turnover_lignin")

At the end of this PR, we can simple replace the hardcoded current assignment values in calculate_turnover with the values from the constants files. And we should test that a model configuration successfully alters the resulting value!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant