Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in intermediate links when app source URL doesn't have a path #1816

Open
lirre8 opened this issue Aug 30, 2024 · 0 comments
Open

Bug in intermediate links when app source URL doesn't have a path #1816

lirre8 opened this issue Aug 30, 2024 · 0 comments

Comments

@lirre8
Copy link

lirre8 commented Aug 30, 2024

Having an issue when using intermediate links for an app source URL without path. I believe I found the issue:

if (ambiguousUrl.startsWith('/') || currPathSegments.isEmpty) {
absoluteUrl = '${referenceAbsoluteUrl.origin}$ambiguousUrl';

If ambiguousUrl doesn't start with / and currPathSegments is empty the if statement will be true and absoluteUrl will be assigned an invalid value without /. Shouldn't it just be:

if (ambiguousUrl.startsWith('/')) { 
   absoluteUrl = '${referenceAbsoluteUrl.origin}$ambiguousUrl'; 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant