fix(lint): fix lint errors

Author: Walker Leite

.editorconfig

@@ -0,0 +1,13 @@
+# EditorConfig helps developers define and maintain consistent
+# coding styles between different editors and IDEs
+# http://editorconfig.org
+
+root = true
+
+[*]
+indent_style = space
+indent_size = 2
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true

.eslintignore

@@ -1,2 +1,2 @@
 test-project
-template
+template

.eslintrc

@@ -20,4 +20,4 @@
         "require": true,
         "request": true
     }
-}
+}

template/.eslintrc

@@ -25,7 +25,9 @@
           "gulp-tasks/**/*.js"
         ]
       }
-    ]
+    ],
+    "import/extensions": "off",
+    "no-param-reassign": "off"
   },
   "globals": {
     "expect": true,

template/client/store/modules/auth/actions.js

@@ -14,10 +14,10 @@ export function syncToken({commit, dispatch}) {
 /**
  * Sync router for auth
  */
-export function syncRouter({state, dispatch}, router) {
+export function syncRouter({state, dispatch}, myRouter) {
   dispatch('syncToken');
 
-  router.beforeEach((to, from, next) => {
+  myRouter.beforeEach((to, from, next) => {
     if (to.matched.some(record => record.meta.requiresAuth)) {
       // this route requires auth, check if logged in
       // if not, redirect to login page (except when it's profile route and
@@ -103,7 +103,7 @@ export function loadAccount({commit}, userId) {
  * @param  {String}   newPassword  new password
  * @return {Promise}              promise of the password reset
  */
-export function resetPassword({commit, state}, {oldPassword, newPassword}) {
+export function resetPassword(ctx, {oldPassword, newPassword}) {
   return loopback
     .post(
       '/Accounts/change-password',
@@ -117,7 +117,7 @@ export function resetPassword({commit, state}, {oldPassword, newPassword}) {
  * @param  {String}   email        user email
  * @return {Promise}               promise of the sent email
  */
-export function rememberPassword({commit}, email) {
+export function rememberPassword(ctx, email) {
   return loopback
     .post('/Accounts/reset', {email});
 }

template/client/view/mixins/notification.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-vars */
 export default {
   methods: {
     notifySuccess(msg) {

template/common/models/message.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-param-reassign */
 export default function(Message) {
   Message.greet = (msg, cb) => {
     process.nextTick(() => {

template/gulp-tasks/build.js

@@ -65,11 +65,13 @@ gulp.task('build:client', ['copy:client'], () => {
     .pipe(gulp.dest(dirs.buildClient));
 });
 
-gulp.task('build:common', () => gulp.src(path.resolve(dirs.srcCommon, '**/*.js'))
-  .pipe(sourcemaps.init())
-  .pipe(babel())
-  .pipe(sourcemaps.write('.'))
-  .pipe(gulp.dest(dirs.buildCommon)));
+gulp.task('build:common', () => {
+  return gulp.src(path.resolve(dirs.srcCommon, '**/*.js'))
+    .pipe(sourcemaps.init())
+    .pipe(babel())
+    .pipe(sourcemaps.write('.'))
+    .pipe(gulp.dest(dirs.buildCommon));
+})
 
 gulp.task('build:server', ['copy:server'], () => gulp.src([
   path.resolve(dirs.srcServer, '**/*.js'),

template/gulp-tasks/compilers.js

@@ -1,3 +1,4 @@
+/* eslint no-useless-escape: 0, import/prefer-default-export: 0 */
 import path from 'path';
 import sass from 'vueify/lib/compilers/sass';
 import {dirs} from './config';
@@ -12,19 +13,20 @@ function replaceCuringas(content) {
 }
 
 export function customSass(content, callback, compiler, filePath) {
+  let myContent = content
   const relativePath = path.relative(
     path.dirname(filePath),
     path.resolve(dirs.srcClient, 'style/global.scss')
   );
 
   // Global SCSS
   //
-  content = `@import "${relativePath}";${content}`;
+  myContent = `@import "${relativePath}";${myContent}`;
 
-  content = replaceCuringas(content);
+  myContent = replaceCuringas(myContent);
 
   sass(
-    content,
+    myContent,
     callback,
     compiler,
     filePath

template/gulp-tasks/config.js

@@ -1,3 +1,4 @@
+/* eslint-disable import/prefer-default-export */
 import path from 'path';
 
 export const dirs = {};

template/gulp-tasks/copy.js

@@ -2,14 +2,24 @@ import gulp from 'gulp';
 import path from 'path';
 import {dirs} from './config';
 
-gulp.task('copy:client:fa', () => gulp.src(path.resolve(dirs.modules, 'font-awesome/fonts/*'))
-  .pipe(gulp.dest(path.resolve(dirs.buildClient, 'static/fonts'))));
+gulp.task('copy:client:fa', () => {
+  return gulp
+    .src(path.resolve(dirs.modules, 'font-awesome/fonts/*'))
+    .pipe(gulp.dest(path.resolve(dirs.buildClient, 'static/fonts')));
+})
 
-gulp.task('copy:client', ['copy:client:fa'], () => gulp.src(`${dirs.srcClient}/**/!(*.vue|*.js)`)
-  .pipe(gulp.dest(path.resolve(dirs.buildClient))));
+gulp.task('copy:client', ['copy:client:fa'], () => {
+  return gulp
+    .src(`${dirs.srcClient}/**/!(*.vue|*.js)`)
+    .pipe(gulp.dest(path.resolve(dirs.buildClient)));
+})
 
-gulp.task('copy:package', () => gulp.src(`${dirs.root}/package.json`)
-  .pipe(gulp.dest(path.resolve(dirs.build))));
+gulp.task('copy:package', () => {
+  return gulp.src(`${dirs.root}/package.json`)
+  .pipe(gulp.dest(path.resolve(dirs.build)));
+})
 
-gulp.task('copy:server', () => gulp.src(`${dirs.srcServer}/**/*.json`)
-  .pipe(gulp.dest(path.resolve(dirs.buildServer))));
+gulp.task('copy:server', () => {
+  return gulp.src(`${dirs.srcServer}/**/*.json`)
+  .pipe(gulp.dest(path.resolve(dirs.buildServer)));
+})

template/gulp-tasks/serve.js

@@ -41,7 +41,7 @@ gulp.task('serve:client', ['build:client', 'watch:client'], () => {
     name: 'Client App',
     root: dirs.buildClient,
     livereload: true,
-    middleware: (connect, opt) => [historyApiFallback()],
+    middleware: () => [historyApiFallback()],
   });
 });
 

template/gulp-tasks/test.js

@@ -4,11 +4,15 @@ import {Server} from 'karma';
 import path from 'path';
 import {dirs} from './config';
 
-gulp.task('test:server', () => gulp.src(path.resolve(dirs.testServer, '**/*.spec.js'))
-  .pipe(mocha({
-    compilers: 'js:babel-core/register',
-    require: path.resolve(dirs.test, 'mocha.conf.js'),
-  })));
+gulp.task(
+  'test:server',
+  () =>
+    gulp.src(path.resolve(dirs.testServer, '**/*.spec.js'))
+    .pipe(mocha({
+      compilers: 'js:babel-core/register',
+      require: path.resolve(dirs.test, 'mocha.conf.js'),
+    }))
+);
 
 gulp.task('test:client', (done) => {
   new Server({

template/server/boot/create-admin.js

@@ -17,7 +17,7 @@ export default function createAdmin(server) {
       if (accounts.length < 1) {
         return Account.create({email, password});
       }
-      return null
+      return null;
     })
     .then((account) => {
       if (account) {
@@ -37,11 +37,11 @@ export default function createAdmin(server) {
             ({account, role})
           );
       }
-      return null
+      return null;
     })
     .then((payload) => { // get account and role from payload
       if (payload && payload.account && payload.role) {
-        const myPayload = {...payload}
+        const myPayload = {...payload};
         return myPayload.role.principals.create({
           principalType: RoleMapping.USER,
           principalId: myPayload.account.id,
@@ -50,6 +50,6 @@ export default function createAdmin(server) {
           return myPayload;
         });
       }
-      return null
+      return null;
     });
 }

template/server/models/account.js

@@ -15,7 +15,7 @@ export default function(Account) {
     }, (err) => {
       if (err) return console.log(err);
       console.log('> sending password reset email to:', info.email);
-      return
+      return null;
     });
   });
 }

template/test/client/app.spec.js

@@ -2,8 +2,7 @@ import Vue from 'vue';
 import App from '@/App.vue';
 
 describe('App.vue', () => {
-  let Constructor;
-  let vm;
+  let Constructor, vm;
   {{#extended}}
   const routerView = {
     render: r => r('div', 'mocked component'),