Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to standard? #27

Open
achingbrain opened this issue Jun 18, 2020 · 2 comments
Open

Switch to standard? #27

achingbrain opened this issue Jun 18, 2020 · 2 comments

Comments

@achingbrain
Copy link
Collaborator

This module uses a custom eslint config that requires an old version of eslint.

Attempts to upgrade eslint fail CI with:

npm ERR! peerinvalid The package eslint@7.2.0 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer @satazor/eslint-config@3.2.0 wants eslint@^3.0.0
npm ERR! peerinvalid Peer eslint-plugin-react@6.10.3 wants eslint@^2.0.0 || ^3.0.0

Any objections to just switching to standard for linting?

cc @satazor

@satazor
Copy link
Member

satazor commented Jun 18, 2020

I don’t really like standard because of spaces and commas. However we can switch to using MOXYs, see https://github.com/moxystudio/eslint-config

It seems that just using the base config is enough.

@achingbrain
Copy link
Collaborator Author

I'm not familiar with Moxy's house style, I prefer linting rules that are cross-org and preferably ones that no-one really has the power to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants