Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetTag function uses print function instead of logger #73

Closed
thulasirajkomminar opened this issue Apr 2, 2024 · 2 comments · Fixed by #74
Closed

SetTag function uses print function instead of logger #73

thulasirajkomminar opened this issue Apr 2, 2024 · 2 comments · Fixed by #74
Labels
bug Something isn't working
Milestone

Comments

@thulasirajkomminar
Copy link
Contributor

thulasirajkomminar commented Apr 2, 2024

Specifications

  • Package Version: v0.6.0
  • InfluxDB Version: V3
  • Platform:

Code sample to reproduce problem

WriteData(context.Background(), []any{measurement})

Some measurement has empty tags and some don't. The Write method should use a logger to warn for the empty values but instead it prints the warning which we cannot control over. This will result in lot of logs.

Expected behavior

Should only print the empty tag as warning

Actual behavior

2024-04-02T18:53:19.013+02:00	Empty tags has no effect, tag [*****], measurement [*****]
2024-04-02T18:53:19.013+02:00	Empty tags has no effect, tag [*****], measurement [*****]
2024-04-02T18:53:19.013+02:00	Empty tags has no effect, tag [*****], measurement [*****]
2024-04-02T18:53:19.013+02:00	Empty tags has no effect, tag [*****], measurement [*****]
2024-04-02T18:53:19.013+02:00	Empty tags has no effect, tag [*****], measurement [*****]

Additional info

Code block https://github.com/InfluxCommunity/influxdb3-go/blob/main/influxdb3/point_values.go#L73
No response

@thulasirajkomminar thulasirajkomminar added the bug Something isn't working label Apr 2, 2024
@bednar
Copy link
Member

bednar commented Apr 3, 2024

Hi @thulasirajkomminar,

thanks for using our client.

Is this something you would be willing to help with? All PR is welcome and we will be happy to review your submission.

Best Regards

@thulasirajkomminar
Copy link
Contributor Author

Hi @thulasirajkomminar,

thanks for using our client.

Is this something you would be willing to help with? All PR is welcome and we will be happy to review your submission.

Best Regards

@bednar Mirrored V2 log implementation #74

@bednar bednar added this to the 0.7.0 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants