Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right Links WE stopped working #27

Open
Flummoxed2 opened this issue Mar 25, 2021 · 10 comments
Open

Right Links WE stopped working #27

Flummoxed2 opened this issue Mar 25, 2021 · 10 comments

Comments

@Flummoxed2
Copy link

Stopped working for no reason. Firefox 87.0. Restarted Win10, no change. Thank you.

@Infocatcher
Copy link
Owner

With latest v.0.5b12?

Also please enable debug mode in the options and check out Error/Browser Console (Ctrl+Shift+J to open): should appears [Right Links WE] … messages and (probably) some errors/warnings (unfortunately, not so easy to investigate the source, URL will be like moz-extension://<randomID>/<path>.js).

@grammarbook
Copy link

Version 0.5b12 stopped working for me as well in the following environments:

  • firefox 78.7.0esr (64-bit) under Linux
  • firefox 88.0 (64 bit) under Windows 10

I do not see any output in the browser console, even with Debug mode enabled. I only use "Long left-click". Re-instllation of the add-on does not help.

@grammarbook
Copy link

Hmmm, sometimes, it does work, sometimes it does not. Couldn't figure out necessary / sufficient conditions for neither case.

@Infocatcher
Copy link
Owner

I do not see any output in the browser console, even with Debug mode enabled. I only use "Long left-click". Re-instllation of the add-on does not help.

Strange… on startup should appears setState(true) message (or setState(false) in disabled state).
As I see, may fail only if something went wrong with browser.storage.local.get() browser API.

May be will help complete removal before re-installation (to reset options storage). But this is really strange anyway.

@chuvak2033
Copy link

Hi, today I noticed that a long left-click on a link does not work (for me it opens a link in the current tab). I don't know exactly when it stopped working, I felt that something was wrong, but I realized what was wrong only today)
I immediately looked in the reviews that this is not only me. I tried to uninstall / install - it did not help. Rolled back to version 0.5b9 - it worked. I installed the latest version again - it works. Then I adjusted all the other options and everything stopped working. Using the brute-force method, I found that if you uncheck the "Enabled Keyboard shortcut:" option, it stops working.
For me, this option is not important, but usually during setup I disable it and therefore a long left-click on a link stopped working for me.

@Infocatcher
Copy link
Owner

Using the brute-force method, I found that if you uncheck the "Enabled Keyboard shortcut:" option, it stops working.

"Enabled" checkbox in the options – is a global enabled/disabled state, that will be displayed in toolbar button icon.
To disable keyboard shortcut – use empty string in text field.

@chuvak2033
Copy link

chuvak2033 commented May 4, 2021

I got it, this option enables / disables the add-on, I'll put an empty value there. Before that, there was а hot key F2 there, apparently I pressed it recently and everything stopped working. I slowpoke) Thought by mistake that this option was an enable / disable support hotkey, thanks)

@grammarbook
Copy link

I got it, this option enables / disables the add-on, I'll put an empty value there. Before that, there was а hot key F2 there, apparently I pressed it recently and everything stopped working. I slowpoke) Thought by mistake that this option was an enable / disable support hotkey, thanks)

May be I was mistaken in the same way. For me, it comes as a surprise that the "Enabled" checkbox does not refer to the keyboard shortcut but to the activation of the add-on. This misunderstanding is facilitated by the presence of the other on- / off-switch which is common to all add-ons, see the green ellipse in screenshot 1. In addition, these two switches are not kept in sync, see screenshot 2. Therefore, I'd recommend to remove the "Enabled" checkbox.
screenshot_1
screenshot_2

@Gitoffthelawn
Copy link
Contributor

Another choice to improve the UI/UX is to add a checkbox to the left of the "Keyboard shortcut" string and make that checkbox the control to toggle the availability of the keyboard shortcut (vs having to provide an empty keyboard shortcut).

Then the "Enabled" string can either be removed or renamed to something more easily understood, perhaps "Enable extension functionality" or "Extension functionality enabled".

@grammarbook
Copy link

I fully agree with the suggestion of Gitoffthelawn. By the way: Since I moved the Right Links WE icon (which also reflects the internal on/off state of the add-on) to the overflow menu of the Firefox toolbar, I also missed the second visual indicator of the add-on's internal state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants