fix: improve favicon for md fixes #298

Signed-off-by: Innei <i@innei.in>
Innei · Feb 17, 2024 · a84cb55 · a84cb55
1 parent 1a08436
commit a84cb55
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/src/components/modules/dashboard/writing/TitleExtra.tsx b/src/components/modules/dashboard/writing/TitleExtra.tsx
@@ -39,7 +39,7 @@ export const TitleExtra = <T extends RequiredField & OptionalField>(props: {
                 window.open(url?.data, '_blank')
               }}
             >
-              <i className="icon-[mingcute--external-link-line]" />
+              <i className="icon-[mingcute--arrow-right-up-line]" />
             </MotionButtonBase>
           </div>
         </div>

diff --git a/src/components/ui/link/MLink.tsx b/src/components/ui/link/MLink.tsx
@@ -63,13 +63,15 @@ export const MLink: FC<{
               {children}
             </a>
 
-            <i className="icon-[mingcute--external-link-line] translate-y-[2px]" />
+            <i className="icon-[mingcute--arrow-right-up-line] translate-y-[2px] opacity-70" />
           </span>
         ),
         [handleRedirect, children, href, title],
       )}
     >
-      <span>{href}</span>
+      <a href={href} target="_blank" rel="noreferrer">
+        <span>{href}</span>
+      </a>
     </FloatPopover>
   )
 })

diff --git a/src/components/ui/rich-link/Favicon.tsx b/src/components/ui/rich-link/Favicon.tsx
@@ -110,7 +110,12 @@ export const Favicon: Component<FaviconProps> = (props) => {
   if (!type2IconMap[nextSource]) return null
 
   return (
-    <span className={clsxm('mr-1 align-text-bottom [&_svg]:inline', className)}>
+    <span
+      className={clsxm(
+        'mr-1 inline-flex [&_svg]:inline [&_svg]:!h-[0.8rem]',
+        className,
+      )}
+    >
       {type2IconMap[nextSource]}
     </span>
   )