Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Save scene from view #181

Open
LoicCadour opened this issue Nov 8, 2016 · 6 comments
Open

Update Save scene from view #181

LoicCadour opened this issue Nov 8, 2016 · 6 comments

Comments

@LoicCadour
Copy link

We can currently save a scene directly from the view, but in this scene the vtk meshes have all the metadata we added recently.
Resulting eventually in a bad conversion of these meshes to CARTO.

In the pipeline we can export scenes in the right way at the very last step.

Let's homogenise with this latter way.

@mathildemerle
Copy link

What do you mean: we need to remove the saving directly from the view? What kind of metadata are added?

@LoicCadour
Copy link
Author

No, make the view use the "without-metaData" way.
The metaData are the one needed for the pipelines; there are many: SliceThickness, Orientation, ...
Export a vtk and open it in a text editor, you'll see many MUSIC metaData.

@mathildemerle
Copy link

This issue is solved by https://github.com/Inria-Asclepios/music/pull/471 isn't it @LoicCadour ?

@LoicCadour
Copy link
Author

No, this issue is about scene saving.
It's not a priority since, with the new Viewer, the scene saving will not be needed in the VT pipeline anymore.
But I think we should keep this issue open to remember that scene saving is still not homogenised.

@mathildemerle
Copy link

What i meant was that we differentiate the Carto and Scene buttons. Scene does not have to be valid for Carto. That's why i was saying that this issue is not relevant anymore with the PR :)

@LoicCadour
Copy link
Author

Of course scenes still have to be valid for Carto.
The PR you quoted can be used for treating patient in Bordeaux, but in other centres, they still receive scenes; then they export in Carto with MUSIC Viewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants