Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch error patching match #173

Open
1 of 4 tasks
KwikKill opened this issue Oct 4, 2024 · 0 comments
Open
1 of 4 tasks

Catch error patching match #173

KwikKill opened this issue Oct 4, 2024 · 0 comments
Labels
bug Something isn't working priority:medium Medium Priority

Comments

@KwikKill
Copy link
Member

KwikKill commented Oct 4, 2024

Type of Issue

  • Bug
  • Feature Request
  • Documentation
  • Other

Description

When a match is ongoing, players can send the scores and the length of the match to the backend.
There is validation missing for the time. For example, if "5 min" is sent, this will cause a crash and the match will not be ended.
We should catch this so it returns a 400 instead of a strange state where the score is added but the match is still ongoing.

@KwikKill KwikKill added bug Something isn't working priority:medium Medium Priority labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:medium Medium Priority
Projects
None yet
Development

No branches or pull requests

1 participant