Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Support for absence of state parameter in logout response #106

Open
clement-dufaure opened this issue Apr 10, 2024 · 2 comments
Labels
question Further information is requested

Comments

@clement-dufaure
Copy link
Collaborator

Previous version of this plugin had a switch to allow for the absence of the state parameter in franceconnect logout response (for csrf protection)

Shoud we reintroduce this switch in admin panel or should we definitively remove support for accepting logout responses without state parameter ?

It's about code around https://github.com/InseeFr/Keycloak-FranceConnect/blob/master/src/main/java/fr/insee/keycloak/providers/common/AbstractBaseIdentityProvider.java#L202C1-L211C100

@clement-dufaure clement-dufaure added the question Further information is requested label Apr 10, 2024
@clement-dufaure clement-dufaure changed the title [QUESTION] Missing state in logout response [QUESTION] Support for absence of state parameter in logout response Apr 10, 2024
@lme-atolcd
Copy link
Contributor

Shoud we reintroduce this switch in admin panel or should we definitively remove support for accepting logout responses without state parameter ?

As stated in the FranceConnect documentation for the Logout Endpoint, the state parameter is required. So I think we could drop support for logout responses without state parameter.

@micedre
Copy link
Collaborator

micedre commented Apr 10, 2024

Fyi, this switch was introduced because France connect stopped sending the parameter in logout response (see issue #6).
If this was corrected by FC, it seems best to not reintroduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants