Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused positioning in Table component #239

Open
nsenave opened this issue Jun 13, 2024 · 1 comment · Fixed by #260
Open

Remove unused positioning in Table component #239

nsenave opened this issue Jun 13, 2024 · 1 comment · Fixed by #260
Assignees
@nsenave

Comments

@nsenave
Copy link
Contributor

nsenave commented Jun 13, 2024

The Table component has a positioning property that is unused in Lunatic (it is not present in Lunatic's questionnaire json schema):

https://github.com/InseeFr/Lunatic/blob/9026d46c17a069caf5f4e3e7a64e37f94b804d62/lunatic-schema.json

This unused property should be removed.
@nsenave nsenave self-assigned this Jun 13, 2024
@nsenave nsenave linked a pull request Aug 8, 2024 that will close this issue
refactor: mark table positioning property as 'for removal' #260
Merged
@nsenave
Copy link
Contributor Author

nsenave commented Aug 12, 2024

To do in a later release: remove this attribute completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsenave nsenave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: mark table positioning property as 'for removal' InseeFr/Lunatic-Model
1 participant
@nsenave