Add login-username support
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mstrodl
commented
Oct 4, 2022
| @@ -59,6 +59,7 @@ | |||
| "react": "^16.8.0 || ^17.0.0 || ^18.0.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/core": "^7.0.0", | |||
There was a problem hiding this comment.
I was getting peer dependency errors without this. Let me know if this is an issue
Mstrodl
commented
Oct 4, 2022
| @@ -13,6 +13,7 @@ import { Reflect } from "tsafe/Reflect"; | |||
| // https://github.com/keycloak/keycloak/blob/main/services/src/main/java/org/keycloak/forms/login/freemarker/Templates.java | |||
| export const pageIds = [ | |||
| "login.ftl", | |||
| "login-username.ftl", | |||
There was a problem hiding this comment.
These didn't appear in any particular order. Is this an okay place to put this?
garronej
added
the
hacktoberfest-accepted
|
Hey @Mstrodl thank you so much for this great contribution. Would you run |
Shown for the "Username Form" login step. I would also like to work on: - `login-password.ftl` - `webauthn-authenticate.ftl` But first want to see opinions on this!
Mstrodl
force-pushed
the
feature/mstrodl/login-username
branch
from
02bc084 to
e3a0639
Compare
Hmm, I did do this. Looks like I forgot to regenerate the lockfile (I use |
|
@Mstrodl I've updated the log and released a new version Thanks again! � |
|
@all-contributors please add @Mstrodl for code |
|
I've put up a pull request to add @Mstrodl! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shown for the "Username Form" login step.
I would also like to work on:
login-password.ftlwebauthn-authenticate.ftlBut first want to see opinions on this!
p.s. I would appreciate a
hacktoberfest-acceptedlabel if you're okay with it!