Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOIN_USE_COMPOSE_VIEWMODEL does not work #150

Closed
master-lzh opened this issue Jul 27, 2024 · 4 comments
Closed

KOIN_USE_COMPOSE_VIEWMODEL does not work #150

master-lzh opened this issue Jul 27, 2024 · 4 comments

Comments

@master-lzh
Copy link

Describe the bug
No matter where I add

ksp { 
    arg("KOIN_USE_COMPOSE_VIEWMODEL", "true")
}

, it still import org.koin.androidx.viewmodel.dsl.viewModel

Expected behavior
import org.koin.compose.viewmodel.dsl.viewModel

Koin project used and used version (please complete the following information):
koin-ksp-compiler 1.4.0-RC3

Additional moduleDefinition
Add any other moduleDefinition about the problem here.

@kibettheophilus
Copy link
Contributor

Hi @master-lzh , can you try removing the ksp argument? Seems it is deprecated as of version 1.4.*.

@frogggias
Copy link
Contributor

@kibettheophilus The issue is in configuring the code writer for the default module. See fixed #157 .

@kibettheophilus
Copy link
Contributor

@frogggias you are right, hadn't checked the imports well on the generated file.

@arnaudgiuliani
Copy link
Member

yes, did you tried in RC4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants