Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Thermosiphon #116

Closed
rongi opened this issue May 3, 2018 · 4 comments
Closed

No Thermosiphon #116

rongi opened this issue May 3, 2018 · 4 comments
Labels
core status:accepted accepted to be developed
Milestone

Comments

@rongi
Copy link

rongi commented May 3, 2018

I've looked through the Koin 1.0.0 Roadmap and was concerned by the fact that there are no plans to add any Thermosiphon mentions to the Koin documentation. As DI library developers you know better than me, of course, that no DI library can be considered complete without a proper Thermosiphon mention. Is it just something that you forgot to write down or maybe it is just so obvious, that you don't think that it is necessary to bother yourself with adding the task? Thanks.

@arnaudgiuliani
Copy link
Member

arnaudgiuliani commented May 4, 2018

Hi,

documentation is under rewrite for next release. We want to make it accessible to help contribution on it. Feel free to contribute to next documentation.

The thermosiphon story a recurrent example in the dagger litterature. It's then interesting to have such example in the core documentation.

@arnaudgiuliani arnaudgiuliani added this to the 1.0.0 milestone May 4, 2018
@arnaudgiuliani
Copy link
Member

Hello @rongi,

Koin examples has been started. The coffee maker example is available here: https://github.com/Ekito/koin/tree/1.0.0/koin-projects/examples/coffee-maker

The koin-core example documentation will be updated about it.

@rongi
Copy link
Author

rongi commented May 31, 2018

@arnaudgiuliani
Copy link
Member

Check #143 for more info about new documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core status:accepted accepted to be developed
Projects
None yet
Development

No branches or pull requests

2 participants