Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route support to koinNavGraphViewModel() extension #1818

Closed
SebastianHelzer opened this issue Mar 11, 2024 · 2 comments
Closed

Add route support to koinNavGraphViewModel() extension #1818

SebastianHelzer opened this issue Mar 11, 2024 · 2 comments

Comments

@SebastianHelzer
Copy link

Is your feature request related to a problem? Please describe.
The koinNavGraphViewModel() extension is perfect for scoping ViewModels to nav graphs but when using the nav graph DSL graph ids are inaccessible.

Describe the solution you'd like
It would be nice if the extension function also supports routes. This issue was reported earlier as #1476 and addressed in this PR #1473 but the issue and PR were closed without being merged in.

Describe alternatives you've considered
Currently I use my own variant of the extension function which does support route based navigation. It would however be better if I could just use the koinNavGraphViewModel() extension function.

Target Koin project
koin-androidx-navigation

@SebastianHelzer
Copy link
Author

This will be resolved with the merging of #1819

Copy link

stale bot commented Aug 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:wontfix label Aug 9, 2024
@stale stale bot closed this as completed Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant