BUG: Double scaling introduced in refactoring

The moving marginal pdf was double scaled by the normalization factor. During the previous refactorings the scaling was decoupled from the computations for the fixed and marginal computations, but was not removed from the subsequent marginal computation. Printf trace dumps of every variable value before and after April 10, 2020 changes.
InsightSoftwareConsortium · May 6, 2020 · 355c6cb · 355c6cb
1 parent e747b0a
commit 355c6cb
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/Modules/Registration/Metricsv4/include/itkMattesMutualInformationImageToImageMetricv4.hxx b/Modules/Registration/Metricsv4/include/itkMattesMutualInformationImageToImageMetricv4.hxx
@@ -358,7 +358,6 @@ MattesMutualInformationImageToImageMetricv4<TFixedImage,
       {
         currMarginalBin += *colptr;
       }
-      currMarginalBin *= normalizationFactor;
     }
   }
 

diff --git a/Testing/Data/Baseline/Registration/ImageRegistration4Test.png.md5 b/Testing/Data/Baseline/Registration/ImageRegistration4Test.png.md5
@@ -1 +1 @@
-c40bf186ebd70003837afc65d999f8f1
+1fa40e8d13e22f06fefb518a9115acbd
diff --git a/Testing/Data/Baseline/Registration/ImageRegistration4Test.png.sha512 b/Testing/Data/Baseline/Registration/ImageRegistration4Test.png.sha512
-Original file line number
+Diff line change
@@ Expand Up / @@ -358,7 +358,6 @@ MattesMutualInformationImageToImageMetricv4<TFixedImage, @@
           {
             currMarginalBin += *colptr;
           }
-          currMarginalBin *= normalizationFactor;
         }
       }
@@ Expand Down @@
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		c40bf186ebd70003837afc65d999f8f1
		1fa40e8d13e22f06fefb518a9115acbd