STYLE: Use MakeFilled, () or {}, instead of Vector(const ValueType &)

A call to `MakeFilled<VectorType>(value)` expresses more clearly than
`Vector(const ValueType &)` that an _entire_ Vector is to be filled by
the specific scalar value.

Zero-initialization of a Vector is achieved in the most generic way, by
an empty pair of parentheses `()` or an empty pair of braces `{}`,
rather than by passing 0.0 to the explicit `Vector(const ValueType &)`
constructor.

Modules/Core/Common/include/itkAnnulusOperator.h

@@ -248,7 +248,7 @@ class ITK_TEMPLATE_EXPORT AnnulusOperator : public NeighborhoodOperator<TPixel,
   PixelType   m_InteriorValue{ NumericTraits<PixelType>::ZeroValue() };
   PixelType   m_AnnulusValue{ NumericTraits<PixelType>::OneValue() };
   PixelType   m_ExteriorValue{ NumericTraits<PixelType>::ZeroValue() };
-  SpacingType m_Spacing{ 1.0 };
+  SpacingType m_Spacing{ MakeFilled<SpacingType>(1.0) };
 };
 } // namespace itk
 

Modules/Core/Common/include/itkImageBase.h

@@ -810,7 +810,7 @@ class ITK_TEMPLATE_EXPORT ImageBase : public DataObject
   /** Origin, spacing, and direction in physical coordinates. This variables are
    * protected for efficiency.  They are referenced frequently by
    * inner loop calculations. */
-  SpacingType   m_Spacing{ 1.0 };
+  SpacingType   m_Spacing{ MakeFilled<SpacingType>(1.0) };
   PointType     m_Origin{};
   DirectionType m_Direction{ DirectionType::GetIdentity() };
   DirectionType m_InverseDirection{ DirectionType::GetIdentity() };

Modules/Core/Common/include/itkNumericTraitsFixedArrayPixel.h

@@ -201,10 +201,10 @@ class NumericTraits<FixedArray<T, D>>
 #define itkStaticNumericTraitsGenericArrayMacro(GENERIC_ARRAY, T, D)                    \
   template <>                                                                           \
   ITKCommon_EXPORT const GENERIC_ARRAY<T, D> NumericTraits<GENERIC_ARRAY<T, D>>::Zero = \
-    GENERIC_ARRAY<T, D>((T)(NumericTraits<T>::Zero));                                   \
+    MakeFilled<GENERIC_ARRAY<T, D>>(NumericTraits<T>::Zero);                            \
   template <>                                                                           \
   ITKCommon_EXPORT const GENERIC_ARRAY<T, D> NumericTraits<GENERIC_ARRAY<T, D>>::One =  \
-    GENERIC_ARRAY<T, D>((T)(NumericTraits<T>::One));
+    MakeFilled<GENERIC_ARRAY<T, D>>(NumericTraits<T>::One);
 
 //
 // List here the array dimension specializations of these static

Modules/Core/Common/include/itkNumericTraitsVectorPixel.h

@@ -72,43 +72,43 @@ class NumericTraits<Vector<T, D>>
   static const Self
   max(const Self &)
   {
-    return Self(NumericTraits<T>::max());
+    return MakeFilled<Self>(NumericTraits<T>::max());
   }
 
   static const Self
   min(const Self &)
   {
-    return Self(NumericTraits<T>::min());
+    return MakeFilled<Self>(NumericTraits<T>::min());
   }
 
   static const Self
   max()
   {
-    return Self(NumericTraits<T>::max());
+    return MakeFilled<Self>(NumericTraits<T>::max());
   }
 
   static const Self
   min()
   {
-    return Self(NumericTraits<T>::min());
+    return MakeFilled<Self>(NumericTraits<T>::min());
   }
 
   static const Self
   NonpositiveMin()
   {
-    return Self(NumericTraits<T>::NonpositiveMin());
+    return MakeFilled<Self>(NumericTraits<T>::NonpositiveMin());
   }
 
   static const Self
   ZeroValue()
   {
-    return Self(NumericTraits<T>::ZeroValue());
+    return MakeFilled<Self>(NumericTraits<T>::ZeroValue());
   }
 
   static const Self
   OneValue()
   {
-    return Self(NumericTraits<T>::OneValue());
+    return MakeFilled<Self>(NumericTraits<T>::OneValue());
   }
 
   static const Self

Modules/Core/Common/test/itkImageBaseGTest.cxx

@@ -130,8 +130,8 @@ CheckInvalidSpacingExceptions()
 
   // Test exceptions
   const SpacingType initialSpacing = imageBase->GetSpacing();
-  const SpacingType negativeSpacing(-1.0);
-  const SpacingType zeroSpacing(0.0);
+  const auto        negativeSpacing = itk::MakeFilled<SpacingType>(-1.0);
+  const SpacingType zeroSpacing{};
 
 #if !defined(ITK_LEGACY_REMOVE)
   // Only a warning is displayed

Modules/Core/ImageFunction/include/itkGaussianDerivativeImageFunction.hxx

@@ -152,7 +152,7 @@ GaussianDerivativeImageFunction<TInputImage, TOutput>::RecomputeGaussianKernel()
   else
   {
     using SpacingType = typename TInputImage::SpacingType;
-    const SpacingType spacing = m_UseImageSpacing ? inputImage->GetSpacing() : SpacingType(1);
+    const SpacingType spacing = m_UseImageSpacing ? inputImage->GetSpacing() : MakeFilled<SpacingType>(1);
 
     for (unsigned int direction = 0; direction < Self::ImageDimension; ++direction)
     {

Modules/Core/ImageFunction/test/itkLinearInterpolateImageFunctionTest.cxx

@@ -215,7 +215,7 @@ RunLinearInterpolateTest()
 
                     const InterpolatedVectorType & vectorpixel = vectorinterpolator->Evaluate(point);
 
-                    const InterpolatedVectorType expectedvector(expectedValue);
+                    const auto expectedvector = itk::MakeFilled<InterpolatedVectorType>(expectedValue);
 
                     const AccumulatorType & errornorm = (expectedvector - vectorpixel).GetNorm();
 

Modules/Core/ImageFunction/test/itkNearestNeighborInterpolateImageFunctionTest.cxx

@@ -179,7 +179,7 @@ itkNearestNeighborInterpolateImageFunctionTest(int, char *[])
 
             // test image of vectors
             const InterpolatedVectorType vectorpixel = vectorinterpolator->Evaluate(point);
-            const InterpolatedVectorType expectedvector(expectedValue);
+            const auto                   expectedvector = itk::MakeFilled<InterpolatedVectorType>(expectedValue);
             const double                 errornorm = (expectedvector - vectorpixel).GetNorm();
 
             if (errornorm > 0)

Modules/Core/SpatialObjects/include/itkImageMaskSpatialObject.hxx

@@ -75,7 +75,7 @@ ImageMaskSpatialObject<TDimension, TPixel>::ComputeMyBoundingBox()
     typename Superclass::ContinuousIndexType maxContinuousIndex{ minIndex + boundingBoxInIndexSpace.GetSize() };
 
     // Allow a margin of half a pixel in each direction.
-    const typename SpatialObject<TDimension>::VectorType half_pixel_size{ 0.5 };
+    const auto half_pixel_size = MakeFilled<typename SpatialObject<TDimension>::VectorType>(0.5);
     minContinuousIndex -= half_pixel_size;
     maxContinuousIndex -= half_pixel_size;
 

Modules/Core/SpatialObjects/test/itkSpatialObjectToImageStatisticsCalculatorTest.cxx

@@ -82,7 +82,7 @@ itkSpatialObjectToImageStatisticsCalculatorTest(int, char *[])
   std::cout << "Sample mean = " << calculator->GetMean() << std::endl;
   std::cout << "Sample covariance = " << calculator->GetCovarianceMatrix();
 
-  if (calculator->GetMean() != CalculatorType::VectorType(255) ||
+  if (calculator->GetMean() != itk::MakeFilled<CalculatorType::VectorType>(255) ||
       itk::Math::NotAlmostEquals(calculator->GetCovarianceMatrix()[0][0],
                                  itk::NumericTraits<CalculatorType::MatrixType::ValueType>::ZeroValue()))
   {

Modules/Core/Transform/include/itkBSplineTransformInitializer.hxx

@@ -171,7 +171,7 @@ BSplineTransformInitializer<TTransform, TImage>::InitializeTransform() const
   {
     minAngle[d] = NumericTraits<double>::max();
 
-    VectorType vectorAxis(0.0);
+    VectorType vectorAxis{};
     vectorAxis[d] = 1.0;
 
     for (unsigned int i = 0; i < SpaceDimension; ++i)

Modules/Core/Transform/test/itkComposeScaleSkewVersor3DTransformTest.cxx

@@ -62,7 +62,7 @@ itkComposeScaleSkewVersor3DTransformTest(int, char *[])
 
     auto transform = TransformType::New();
 
-    VectorType axis(1.5);
+    auto axis = itk::MakeFilled<VectorType>(1.5);
 
     ValueType angle = 120.0 * std::atan(1.0) / 45.0;
 
@@ -109,7 +109,7 @@ itkComposeScaleSkewVersor3DTransformTest(int, char *[])
 
     auto rotation = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 120.0; // turn 120 degrees
 
@@ -267,7 +267,7 @@ itkComposeScaleSkewVersor3DTransformTest(int, char *[])
 
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
 
@@ -343,7 +343,7 @@ itkComposeScaleSkewVersor3DTransformTest(int, char *[])
     std::cout << " Exercise the SetIdentity() method " << std::endl;
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
 
@@ -396,8 +396,8 @@ itkComposeScaleSkewVersor3DTransformTest(int, char *[])
     std::cout << " Exercise the Scaling methods " << std::endl;
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
-    const double           angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
+    auto         axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
+    const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
     transform->SetRotation(axis, angle);
 
     TransformType::InputPointType center;

Modules/Core/Transform/test/itkScaleSkewVersor3DTransformTest.cxx

@@ -68,7 +68,7 @@ itkScaleSkewVersor3DTransformTest(int, char *[])
 
     auto transform = TransformType::New();
 
-    VectorType axis(1.5);
+    auto axis = itk::MakeFilled<VectorType>(1.5);
 
     ValueType angle = 120.0 * std::atan(1.0) / 45.0;
 
@@ -112,7 +112,7 @@ itkScaleSkewVersor3DTransformTest(int, char *[])
 
     auto rotation = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 120.0; // turn 120 degrees
 
@@ -270,7 +270,7 @@ itkScaleSkewVersor3DTransformTest(int, char *[])
 
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
 
@@ -409,7 +409,7 @@ itkScaleSkewVersor3DTransformTest(int, char *[])
     std::cout << " Exercise the SetIdentity() method " << std::endl;
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
 
@@ -464,7 +464,7 @@ itkScaleSkewVersor3DTransformTest(int, char *[])
     std::cout << " Exercise the Scaling methods " << std::endl;
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
 

Modules/Core/Transform/test/itkScaleVersor3DTransformTest.cxx

@@ -63,7 +63,7 @@ itkScaleVersor3DTransformTest(int, char *[])
 
     transform->Print(std::cout);
 
-    VectorType axis(1.5);
+    auto axis = itk::MakeFilled<VectorType>(1.5);
 
     ValueType angle = 120.0 * std::atan(1.0) / 45.0;
 
@@ -126,7 +126,7 @@ itkScaleVersor3DTransformTest(int, char *[])
 
     auto rotation = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 120.0; // turn 120 degrees
 
@@ -284,7 +284,7 @@ itkScaleVersor3DTransformTest(int, char *[])
 
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
 
@@ -421,7 +421,7 @@ itkScaleVersor3DTransformTest(int, char *[])
     std::cout << " Exercise the SetIdentity() method " << std::endl;
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
 
@@ -470,7 +470,7 @@ itkScaleVersor3DTransformTest(int, char *[])
     std::cout << " Exercise the Scaling methods " << std::endl;
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
 

Modules/Core/Transform/test/itkSimilarity3DTransformTest.cxx

@@ -74,7 +74,7 @@ itkSimilarity3DTransformTest(int, char *[])
       return EXIT_FAILURE;
     }
 
-    VectorType axis(1.5);
+    auto axis = itk::MakeFilled<VectorType>(1.5);
 
     ValueType angle = 120.0 * std::atan(1.0) / 45.0;
 
@@ -114,7 +114,7 @@ itkSimilarity3DTransformTest(int, char *[])
 
     auto rotation = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 120.0; // turn 120 degrees
 
@@ -270,7 +270,7 @@ itkSimilarity3DTransformTest(int, char *[])
 
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
 
@@ -396,7 +396,7 @@ itkSimilarity3DTransformTest(int, char *[])
     std::cout << " Exercise the SetIdentity() method " << std::endl;
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
 
@@ -443,7 +443,7 @@ itkSimilarity3DTransformTest(int, char *[])
     std::cout << " Exercise the Scaling methods " << std::endl;
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
 

Modules/Core/Transform/test/itkVersorRigid3DTransformTest.cxx

@@ -65,7 +65,7 @@ itkVersorRigid3DTransformTest(int, char *[])
 
     auto transform = TransformType::New();
 
-    VectorType axis(1.5);
+    auto axis = itk::MakeFilled<VectorType>(1.5);
 
     ValueType angle = 120.0 * std::atan(1.0) / 45.0;
 
@@ -106,7 +106,7 @@ itkVersorRigid3DTransformTest(int, char *[])
 
     auto rotation = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 120.0; // turn 120 degrees
 
@@ -264,7 +264,7 @@ itkVersorRigid3DTransformTest(int, char *[])
 
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
 
@@ -385,7 +385,7 @@ itkVersorRigid3DTransformTest(int, char *[])
     std::cout << " Exercise the SetIdentity() method " << std::endl;
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees
 

Modules/Core/Transform/test/itkVersorTransformTest.cxx

@@ -65,7 +65,7 @@ itkVersorTransformTest(int, char *[])
 
     auto transform = TransformType::New();
 
-    VectorType axis(1.5);
+    auto axis = itk::MakeFilled<VectorType>(1.5);
 
     ValueType angle = 120.0 * std::atan(1.0) / 45.0;
 
@@ -103,7 +103,7 @@ itkVersorTransformTest(int, char *[])
 
     auto rotation = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 120.0; // turn 120 degrees
 
@@ -261,7 +261,7 @@ itkVersorTransformTest(int, char *[])
 
     auto transform = TransformType::New();
 
-    itk::Vector<double, 3> axis(1);
+    auto axis = itk::MakeFilled<itk::Vector<double, 3>>(1);
 
     const double angle = (std::atan(1.0) / 45.0) * 30.0; // turn 30 degrees