STYLE: Replace NumericTraits<float> ZeroValue() and OneValue() calls

Replaced `NumericTraits<float>::ZeroValue()` calls by `0.0f`. Also replaced the one call to `itk::NumericTraits<float>::OneValue()`, from inside itkMathTest. Follow-up to similar commits for `double`, but now specific for `float`, as suggested by Dženan Zukić.
InsightSoftwareConsortium · Jan 26, 2022 · a0d4cef · a0d4cef
1 parent 7182b61
commit a0d4cef
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 7 deletions.
diff --git a/Modules/Core/Common/test/itkBoundaryConditionTest.cxx b/Modules/Core/Common/test/itkBoundaryConditionTest.cxx
@@ -170,7 +170,7 @@ itkBoundaryConditionTest(int, char *[])
   SmartIteratorType it2d(sz2, image2D, image2D->GetRequestedRegion());
 
   itk::ConstantBoundaryCondition<ImageType2D> cbc;
-  cbc.SetConstant(itk::NumericTraits<float>::ZeroValue());
+  cbc.SetConstant(0.0f);
   it2d.OverrideBoundaryCondition(&cbc);
 
   SmartIteratorType::NeighborhoodType tempN;

diff --git a/Modules/Core/Common/test/itkMathTest.cxx b/Modules/Core/Common/test/itkMathTest.cxx
@@ -622,8 +622,7 @@ main(int, char *[])
     }
 
     // Test comparison values of different types
-    if (itk::Math::NotExactlyEquals(itk::NumericTraits<float>::OneValue(), 1.0) ||
-        itk::Math::NotExactlyEquals(1.0, static_cast<float>(1)))
+    if (itk::Math::NotExactlyEquals(1.0f, 1.0) || itk::Math::NotExactlyEquals(1.0, 1.0f))
     {
       std::cout << __FILE__ << " " << __LINE__ << " " << f << " == " << d << std::endl;
       testPassStatus = EXIT_FAILURE;

diff --git a/Modules/IO/MINC/test/itkMINCImageIOTest.cxx b/Modules/IO/MINC/test/itkMINCImageIOTest.cxx
@@ -441,7 +441,7 @@ MINCReadWriteTest(const char * fileName, const char * minc_storage_type, double
     success = EXIT_FAILURE;
   }
 
-  float metaDataFloat = itk::NumericTraits<float>::ZeroValue();
+  float metaDataFloat = 0.0f;
   if (!itk::ExposeMetaData<float>(metaDict2, "acquisition:TestFloat", metaDataFloat) || metaDataFloat != 1.2f)
   {
     std::cerr << "Failure reading metaData "

diff --git a/Modules/IO/MeshFreeSurfer/src/itkFreeSurferAsciiMeshIO.cxx b/Modules/IO/MeshFreeSurfer/src/itkFreeSurferAsciiMeshIO.cxx
@@ -307,7 +307,7 @@ FreeSurferAsciiMeshIO ::WritePoints(void * buffer)
     }
     case IOComponentEnum::FLOAT:
     {
-      WritePoints(static_cast<float *>(buffer), outputFile, itk::NumericTraits<float>::ZeroValue());
+      WritePoints(static_cast<float *>(buffer), outputFile, 0.0f);
 
       break;
     }

diff --git a/Modules/Segmentation/LevelSets/include/itkCurvesLevelSetFunction.hxx b/Modules/Segmentation/LevelSets/include/itkCurvesLevelSetFunction.hxx
@@ -57,7 +57,7 @@ CurvesLevelSetFunction<TImageType, TFeatureImageType>::CalculateAdvectionImage()
 
   typename VectorImageType::Pointer gradientImage;
 
-  if (Math::NotAlmostEquals(m_DerivativeSigma, NumericTraits<float>::ZeroValue()))
+  if (Math::NotAlmostEquals(m_DerivativeSigma, 0.0f))
   {
     using DerivativeFilterType = GradientRecursiveGaussianImageFilter<FeatureImageType, VectorImageType>;
 

diff --git a/Modules/Segmentation/LevelSets/include/itkGeodesicActiveContourLevelSetFunction.hxx b/Modules/Segmentation/LevelSets/include/itkGeodesicActiveContourLevelSetFunction.hxx
@@ -46,7 +46,7 @@ GeodesicActiveContourLevelSetFunction<TImageType, TFeatureImageType>::CalculateA
 
   typename VectorImageType::Pointer gradientImage;
 
-  if (Math::NotAlmostEquals(m_DerivativeSigma, NumericTraits<float>::ZeroValue()))
+  if (Math::NotAlmostEquals(m_DerivativeSigma, 0.0f))
   {
     using DerivativeFilterType = GradientRecursiveGaussianImageFilter<FeatureImageType, VectorImageType>;