STYLE: Do not do return; directly after throwing an exception

Any return statement directly after a `throw` (possibly from a call to
`itkExceptionMacro` or `itkGenericExceptionMacro`) is unreachable, by
definition.

Author: N-Dekker

Modules/Bridge/VTK/include/itkVTKImageImport.hxx

@@ -125,7 +125,6 @@ VTKImageImport<TOutputImage>::PropagateRequestedRegion(DataObject * outputPtr)
   if (!output)
   {
     itkExceptionMacro(<< "Downcast from DataObject to my Image type failed.");
-    return;
   }
   Superclass::PropagateRequestedRegion(output);
   if (m_PropagateUpdateExtentCallback)

Modules/Core/Common/include/itkByteSwapper.hxx

@@ -129,7 +129,6 @@ ByteSwapper<T>::SwapRangeFromSystemToBigEndian(T * p, BufferSizeType num)
       return;
     default:
       itkGenericExceptionMacro(<< "Cannot swap number of bytes requested");
-      return;
   }
 }
 

Modules/Core/Common/include/itkImageDuplicator.hxx

@@ -40,7 +40,6 @@ ImageDuplicator<TInputImage>::Update()
   if (!m_InputImage)
   {
     itkExceptionMacro(<< "Input image has not been connected");
-    return;
   }
 
   // Update only if the input image has been modified

Modules/Core/Common/include/itkResourceProbesCollectorBase.hxx

@@ -44,7 +44,6 @@ ResourceProbesCollectorBase<TProbe>::Stop(const char * id)
   if (pos == this->m_Probes.end())
   {
     itkGenericExceptionMacro(<< "The probe \"" << id << "\" does not exist. It can not be stopped.");
-    return;
   }
   pos->second.Stop();
 }

Modules/Core/Common/include/itkSmapsFileParser.hxx

@@ -149,7 +149,6 @@ VMMapFileParser<TVMMapDataType>::ReadFile(const std::string & mapFileLocation)
       if (inputFile.is_open() == false)
       {
         itkGenericExceptionMacro(<< "The VMap file " << mapFileLocation << " could not be open");
-        return;
       }
       // load the file
       inputFile >> this->m_MapData;

Modules/Core/Common/include/itkStreamingImageFilter.hxx

@@ -120,7 +120,6 @@ StreamingImageFilter<TInputImage, TOutputImage>::UpdateOutputData(DataObject * i
   {
     itkExceptionMacro(<< "At least " << this->GetNumberOfRequiredInputs() << " inputs are required but only " << ninputs
                       << " are specified.");
-    return;
   }
 
   /**

Modules/Core/Common/src/itkPlatformMultiThreaderPosix.cxx

@@ -60,7 +60,6 @@ PlatformMultiThreader::MultipleMethodExecute()
     if (m_MultipleMethod[thread_loop] == (ThreadFunctionType) nullptr)
     {
       itkExceptionMacro(<< "No multiple method set for: " << thread_loop);
-      return;
     }
   }
 

Modules/Core/Common/src/itkPlatformMultiThreaderSingle.cxx

@@ -49,7 +49,6 @@ PlatformMultiThreader::MultipleMethodExecute()
     if (m_MultipleMethod[thread_loop] == (ThreadFunctionType)0)
     {
       itkExceptionMacro(<< "No multiple method set for: " << thread_loop);
-      return;
     }
   }
 

Modules/Core/Common/src/itkPlatformMultiThreaderWindows.cxx

@@ -54,7 +54,6 @@ PlatformMultiThreader::MultipleMethodExecute()
     if (m_MultipleMethod[threadCount] == nullptr)
     {
       itkExceptionMacro(<< "No multiple method set for: " << threadCount);
-      return;
     }
   }
   // Using _beginthreadex on a PC

Modules/Core/ImageFunction/include/itkRayCastInterpolateImageFunction.hxx

@@ -1197,7 +1197,6 @@ RayCastHelper<TInputImage, TCoordRep>::InitialiseVoxelPointers()
       err.SetDescription("The ray traversal direction is unset "
                          "- InitialiseVoxelPointers().");
       throw err;
-      return;
     }
   }
 }