STYLE: Pass bool parameters by (const) value, not by const reference

Removed the ampersand (`&`) from declarations of "in" (`const`) `bool` parameters of non-virtual member functions. Following C++ Core Guidelines, April 10, 2022, "For “in” parameters, pass cheaply-copied types by value and others by reference to `const`": https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f16-for-in-parameters-pass-cheaply-copied-types-by-value-and-others-by-reference-to-const
InsightSoftwareConsortium · Jun 2, 2022 · c9a24b1 · c9a24b1
1 parent 0fcfaf1
commit c9a24b1
Show file tree

Hide file tree

Showing 12 changed files with 18 additions and 18 deletions.
diff --git a/Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshEulerOperatorJoinVertexFunction.h b/Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshEulerOperatorJoinVertexFunction.h
@@ -140,7 +140,7 @@ class ITK_TEMPLATE_EXPORT QuadEdgeMeshEulerOperatorJoinVertexFunction
    * \return false else
    */
   bool
-  IsFaceIsolated(QEType * e, const bool & iWasLeftFace, std::stack<TQEType *> & oToBeDeleted);
+  IsFaceIsolated(QEType * e, const bool iWasLeftFace, std::stack<TQEType *> & oToBeDeleted);
 
   bool
   IsSamosa(QEType * e);

diff --git a/Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshEulerOperatorJoinVertexFunction.hxx b/Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshEulerOperatorJoinVertexFunction.hxx
@@ -297,7 +297,7 @@ QuadEdgeMeshEulerOperatorJoinVertexFunction<TMesh, TQEType>::ProcessIsolatedFace
 template <typename TMesh, typename TQEType>
 bool
 QuadEdgeMeshEulerOperatorJoinVertexFunction<TMesh, TQEType>::IsFaceIsolated(QEType *                e,
-                                                                            const bool &            iWasLeftFace,
+                                                                            const bool              iWasLeftFace,
                                                                             std::stack<TQEType *> & oToBeDeleted)
 {
   bool     border;

diff --git a/Modules/Filtering/FFT/include/itkFFTWGlobalConfiguration.h b/Modules/Filtering/FFT/include/itkFFTWGlobalConfiguration.h
@@ -224,7 +224,7 @@ class ITKFFT_EXPORT FFTWGlobalConfiguration : public Object
    * may be written to the cache file
    */
   static void
-  SetNewWisdomAvailable(const bool & v);
+  SetNewWisdomAvailable(const bool v);
   static bool
   GetNewWisdomAvailable();
 
@@ -260,7 +260,7 @@ class ITKFFT_EXPORT FFTWGlobalConfiguration : public Object
    * If true, will create a wisdom file in the location
    */
   static void
-  SetReadWisdomCache(const bool & v);
+  SetReadWisdomCache(const bool v);
   static bool
   GetReadWisdomCache();
 
@@ -272,7 +272,7 @@ class ITKFFT_EXPORT FFTWGlobalConfiguration : public Object
    * If true, will create a wisdom file in the location
    */
   static void
-  SetWriteWisdomCache(const bool & v);
+  SetWriteWisdomCache(const bool v);
   static bool
   GetWriteWisdomCache();
 

diff --git a/Modules/Filtering/FFT/src/itkFFTWGlobalConfiguration.cxx b/Modules/Filtering/FFT/src/itkFFTWGlobalConfiguration.cxx
@@ -744,7 +744,7 @@ FFTWGlobalConfiguration::GetLockMutex()
 }
 
 void
-FFTWGlobalConfiguration::SetNewWisdomAvailable(const bool & v)
+FFTWGlobalConfiguration::SetNewWisdomAvailable(const bool v)
 {
   itkInitGlobalsMacro(PimplGlobals);
   GetInstance()->m_NewWisdomAvailable = v;
@@ -781,7 +781,7 @@ FFTWGlobalConfiguration::SetPlanRigor(const std::string & name)
 }
 
 void
-FFTWGlobalConfiguration::SetReadWisdomCache(const bool & v)
+FFTWGlobalConfiguration::SetReadWisdomCache(const bool v)
 {
   itkInitGlobalsMacro(PimplGlobals);
   GetInstance()->m_ReadWisdomCache = v;
@@ -799,7 +799,7 @@ FFTWGlobalConfiguration::GetReadWisdomCache()
 }
 
 void
-FFTWGlobalConfiguration::SetWriteWisdomCache(const bool & v)
+FFTWGlobalConfiguration::SetWriteWisdomCache(const bool v)
 {
   itkInitGlobalsMacro(PimplGlobals);
   GetInstance()->m_WriteWisdomCache = v;

diff --git a/Modules/Filtering/FastMarching/include/itkFastMarchingQuadEdgeMeshFilterBase.h b/Modules/Filtering/FastMarching/include/itkFastMarchingQuadEdgeMeshFilterBase.h
@@ -135,11 +135,11 @@ class ITK_TEMPLATE_EXPORT FastMarchingQuadEdgeMeshFilterBase : public FastMarchi
         const OutputVectorRealType & iF,
         const NodeType &             iId1,
         const OutputPointType &      iP1,
-        const bool &                 iIsFar1,
+        const bool                   iIsFar1,
         const OutputVectorRealType   iVal1,
         const NodeType &             iId2,
         const OutputPointType &      iP2,
-        const bool &                 iIsFar2,
+        const bool                   iIsFar2,
         const OutputVectorRealType & iVal2) const;
 
 

diff --git a/Modules/Filtering/FastMarching/include/itkFastMarchingQuadEdgeMeshFilterBase.hxx b/Modules/Filtering/FastMarching/include/itkFastMarchingQuadEdgeMeshFilterBase.hxx
@@ -223,11 +223,11 @@ FastMarchingQuadEdgeMeshFilterBase<TInput, TOutput>::Solve(OutputMeshType *
                                                            const OutputVectorRealType & iF,
                                                            const NodeType &             iId1,
                                                            const OutputPointType &      iP1,
-                                                           const bool &                 iIsFar1,
+                                                           const bool                   iIsFar1,
                                                            const OutputVectorRealType   iVal1,
                                                            const NodeType &             iId2,
                                                            const OutputPointType &      iP2,
-                                                           const bool &                 iIsFar2,
+                                                           const bool                   iIsFar2,
                                                            const OutputVectorRealType & iVal2) const
 {
   OutputVectorType Edge1 = iP1 - iCurrentPoint;

diff --git a/Modules/IO/HDF5/src/itkHDF5ImageIO.cxx b/Modules/IO/HDF5/src/itkHDF5ImageIO.cxx
@@ -262,7 +262,7 @@ doesAttrExist(const H5::H5Object & object, const char * const name)
 } // namespace
 
 void
-HDF5ImageIO ::WriteScalar(const std::string & path, const bool & value)
+HDF5ImageIO ::WriteScalar(const std::string & path, const bool value)
 {
   hsize_t       numScalars(1);
   H5::DataSpace scalarSpace(1, &numScalars);

diff --git a/Modules/Numerics/Statistics/include/itkImageToNeighborhoodSampleAdaptor.h b/Modules/Numerics/Statistics/include/itkImageToNeighborhoodSampleAdaptor.h
@@ -129,7 +129,7 @@ class ITK_TEMPLATE_EXPORT ImageToNeighborhoodSampleAdaptor
   GetRegion() const;
 
   void
-  SetUseImageRegion(const bool & flag);
+  SetUseImageRegion(const bool flag);
 
   /** Method to get UseImageRegion flag */
   itkGetConstMacro(UseImageRegion, bool);

diff --git a/Modules/Numerics/Statistics/include/itkImageToNeighborhoodSampleAdaptor.hxx b/Modules/Numerics/Statistics/include/itkImageToNeighborhoodSampleAdaptor.hxx
@@ -207,7 +207,7 @@ ImageToNeighborhoodSampleAdaptor<TImage, TBoundaryCondition>::GetRegion() const
 
 template <typename TImage, typename TBoundaryCondition>
 void
-ImageToNeighborhoodSampleAdaptor<TImage, TBoundaryCondition>::SetUseImageRegion(const bool & flag)
+ImageToNeighborhoodSampleAdaptor<TImage, TBoundaryCondition>::SetUseImageRegion(const bool flag)
 {
   if (flag != m_UseImageRegion)
   {

diff --git a/Modules/Segmentation/LevelSetsv4/include/itkLevelSetContainer.h b/Modules/Segmentation/LevelSetsv4/include/itkLevelSetContainer.h
@@ -141,7 +141,7 @@ class LevelSetContainer<TIdentifier, LevelSetDenseImage<TImage>>
 
   /** Compute information from data object and/or allocate new level set image */
   void
-  CopyInformationAndAllocate(const Self * iOther, const bool & iAllocate)
+  CopyInformationAndAllocate(const Self * iOther, const bool iAllocate)
   {
     LevelSetContainerType              internalContainer = iOther->GetContainer();
     LevelSetContainerConstIteratorType it = internalContainer.begin();

diff --git a/Modules/Segmentation/LevelSetsv4/include/itkUpdateMalcolmSparseLevelSet.h b/Modules/Segmentation/LevelSetsv4/include/itkUpdateMalcolmSparseLevelSet.h
@@ -139,7 +139,7 @@ class ITK_TEMPLATE_EXPORT UpdateMalcolmSparseLevelSet : public Object
   /** Update separately the zero layer for points with positive/negative update values
    *  Move points to -1 or +1 layers */
   void
-  EvolveWithPhasedPropagation(LevelSetLayerType & ioList, LevelSetLayerType & ioUpdate, const bool & iContraction);
+  EvolveWithPhasedPropagation(LevelSetLayerType & ioList, LevelSetLayerType & ioUpdate, const bool iContraction);
 
   /** Make sure the layers are of single pixel thickness only. This method is related
     to the minimal interface function described in the original paper. */

diff --git a/Modules/Segmentation/LevelSetsv4/include/itkUpdateMalcolmSparseLevelSet.hxx b/Modules/Segmentation/LevelSetsv4/include/itkUpdateMalcolmSparseLevelSet.hxx
@@ -253,7 +253,7 @@ template <unsigned int VDimension, typename TEquationContainer>
 void
 UpdateMalcolmSparseLevelSet<VDimension, TEquationContainer>::EvolveWithPhasedPropagation(LevelSetLayerType & ioList,
                                                                                          LevelSetLayerType & ioUpdate,
-                                                                                         const bool & iContraction)
+                                                                                         const bool iContraction)
 {
   itkAssertInDebugAndIgnoreInReleaseMacro(ioList.size() == ioUpdate.size());