STYLE: Remove IsSigned and replace with std::is_signed

Prefer builtin C++11 language features for identifying signed types. :%s#NumericTraits<\([^>]*\)>::IsSigned#std::is_signed<\1>::value#gc
InsightSoftwareConsortium · Nov 14, 2021 · da13473 · da13473
1 parent b3f80bb
commit da13473
Show file tree

Hide file tree

Showing 13 changed files with 17 additions and 17 deletions.
diff --git a/Modules/Core/Common/include/itkMath.h b/Modules/Core/Common/include/itkMath.h
@@ -516,9 +516,9 @@ template <typename TInputType1, typename TInputType2>
 struct AlmostEqualsScalarImplementer
 {
   static constexpr bool TInputType1IsInteger = std::is_integral<TInputType1>::value;
-  static constexpr bool TInputType1IsSigned = itk::NumericTraits<TInputType1>::IsSigned;
+  static constexpr bool TInputType1IsSigned = std::is_signed<TInputType1>::value;
   static constexpr bool TInputType2IsInteger = std::is_integral<TInputType2>::value;
-  static constexpr bool TInputType2IsSigned = itk::NumericTraits<TInputType2>::IsSigned;
+  static constexpr bool TInputType2IsSigned = std::is_signed<TInputType2>::value;
 
   using SelectedVersion = typename AlmostEqualsFunctionSelector<TInputType1IsInteger,
                                                                 TInputType1IsSigned,

diff --git a/Modules/Core/Common/include/itkNumericTraits.h b/Modules/Core/Common/include/itkNumericTraits.h
@@ -1924,7 +1924,7 @@ class NumericTraits<std::complex<TComponent>>
     return val.real() >= 0;
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = false;
   static constexpr bool IsComplex = true;
   static Self

diff --git a/Modules/Core/Common/include/itkNumericTraitsArrayPixel.h b/Modules/Core/Common/include/itkNumericTraitsArrayPixel.h
@@ -112,7 +112,7 @@ class NumericTraits<Array<T>>
     return b;
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 

diff --git a/Modules/Core/Common/include/itkNumericTraitsCovariantVectorPixel.h b/Modules/Core/Common/include/itkNumericTraitsCovariantVectorPixel.h
@@ -143,7 +143,7 @@ class NumericTraits<CovariantVector<T, D>>
     return OneValue();
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 

diff --git a/Modules/Core/Common/include/itkNumericTraitsDiffusionTensor3DPixel.h b/Modules/Core/Common/include/itkNumericTraitsDiffusionTensor3DPixel.h
@@ -144,7 +144,7 @@ class NumericTraits<DiffusionTensor3D<T>>
     return Self(NumericTraits<T>::OneValue());
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 

diff --git a/Modules/Core/Common/include/itkNumericTraitsPointPixel.h b/Modules/Core/Common/include/itkNumericTraitsPointPixel.h
@@ -130,7 +130,7 @@ class NumericTraits<Point<T, D>>
     return OneValue();
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 

diff --git a/Modules/Core/Common/include/itkNumericTraitsRGBAPixel.h b/Modules/Core/Common/include/itkNumericTraitsRGBAPixel.h
@@ -170,7 +170,7 @@ class NumericTraits<RGBAPixel<T>>
     return NumericTraits<typename Self::LuminanceType>::IsNonnegative(val.GetLuminance());
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 

diff --git a/Modules/Core/Common/include/itkNumericTraitsRGBPixel.h b/Modules/Core/Common/include/itkNumericTraitsRGBPixel.h
@@ -170,7 +170,7 @@ class NumericTraits<RGBPixel<T>>
     return NumericTraits<typename Self::LuminanceType>::IsNonnegative(val.GetLuminance());
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 

diff --git a/Modules/Core/Common/include/itkNumericTraitsStdVector.h b/Modules/Core/Common/include/itkNumericTraitsStdVector.h
@@ -131,7 +131,7 @@ class NumericTraits<std::vector<T>>
     return b;
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 

diff --git a/Modules/Core/Common/include/itkNumericTraitsTensorPixel.h b/Modules/Core/Common/include/itkNumericTraitsTensorPixel.h
@@ -143,7 +143,7 @@ class NumericTraits<SymmetricSecondRankTensor<T, D>>
     return OneValue();
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 

diff --git a/Modules/Core/Common/include/itkNumericTraitsVariableLengthVectorPixel.h b/Modules/Core/Common/include/itkNumericTraitsVariableLengthVectorPixel.h
@@ -192,7 +192,7 @@ class NumericTraits<VariableLengthVector<T>>
     return flag;
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 

diff --git a/Modules/Core/Common/include/itkNumericTraitsVectorPixel.h b/Modules/Core/Common/include/itkNumericTraitsVectorPixel.h
@@ -185,7 +185,7 @@ class NumericTraits<Vector<T, D>>
     return flag;
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 

diff --git a/Modules/Core/Common/test/itkNumericTraitsTest.cxx b/Modules/Core/Common/test/itkNumericTraitsTest.cxx
@@ -210,17 +210,17 @@ CheckSignedAndIntegerTraitsSameAsSTDNumericLimits(const char * const name)
     std::cout << "\tERROR:  IsSigned definitions for itk::NumericTraits and std::numeric_limits do not match!! ERROR!!"
               << std::endl;
     std::cout << "\tFor type: \t" << name << std::endl;
-    std::cout << "\tITK signed Value for:\t<  " << name << "  >\tis:\t"
-              << (itk::NumericTraits<T>::IsSigned ? "true" : "false") << std::endl;
+    std::cout << "\tITK signed Value for:\t<  " << name << "  >\tis:\t" << (std::is_signed<T>::value ? "true" : "false")
+              << std::endl;
     std::cout << "\tstd signed Value for:\t<  " << name << "  >\tis:\t"
               << (std::numeric_limits<T>::is_signed ? "true" : "false") << std::endl;
     didTestPass = false;
   }
   else
   {
     std::cout << "\tSUCCESS:  IsSigned definition for itk::NumericTraits matches std::numeric_limits" << std::endl;
-    std::cout << "\tSigned Value for:\t<  " << name << "  >\tis:\t"
-              << (itk::NumericTraits<T>::IsSigned ? "true" : "false") << std::endl;
+    std::cout << "\tSigned Value for:\t<  " << name << "  >\tis:\t" << (std::is_signed<T>::value ? "true" : "false")
+              << std::endl;
   }
 
   // test for IsInteger