STYLE: Remove IsSigned and replace with std::is_signed

hjmjohnson · N-Dekker · commit da13473cb022 · 2021-11-14T01:03:31.000+01:00
Prefer builtin C++11 language features for identifying
signed types.

:%s#NumericTraits&lt;\([^&gt;]*\)&gt;::IsSigned#std::is_signed&lt;\1&gt;::value#gc
diff --git a/Modules/Core/Common/include/itkMath.h b/Modules/Core/Common/include/itkMath.h
@@ -516,9 +516,9 @@ template <typename TInputType1, typename TInputType2>
 struct AlmostEqualsScalarImplementer
 {
   static constexpr bool TInputType1IsInteger = std::is_integral<TInputType1>::value;
-  static constexpr bool TInputType1IsSigned = itk::NumericTraits<TInputType1>::IsSigned;
+  static constexpr bool TInputType1IsSigned = std::is_signed<TInputType1>::value;
   static constexpr bool TInputType2IsInteger = std::is_integral<TInputType2>::value;
-  static constexpr bool TInputType2IsSigned = itk::NumericTraits<TInputType2>::IsSigned;
+  static constexpr bool TInputType2IsSigned = std::is_signed<TInputType2>::value;
 
   using SelectedVersion = typename AlmostEqualsFunctionSelector<TInputType1IsInteger,
                                                                 TInputType1IsSigned,
diff --git a/Modules/Core/Common/include/itkNumericTraits.h b/Modules/Core/Common/include/itkNumericTraits.h
@@ -1924,7 +1924,7 @@ class NumericTraits<std::complex<TComponent>>
     return val.real() >= 0;
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = false;
   static constexpr bool IsComplex = true;
   static Self
diff --git a/Modules/Core/Common/include/itkNumericTraitsArrayPixel.h b/Modules/Core/Common/include/itkNumericTraitsArrayPixel.h
@@ -112,7 +112,7 @@ class NumericTraits<Array<T>>
     return b;
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 
diff --git a/Modules/Core/Common/include/itkNumericTraitsCovariantVectorPixel.h b/Modules/Core/Common/include/itkNumericTraitsCovariantVectorPixel.h
@@ -143,7 +143,7 @@ class NumericTraits<CovariantVector<T, D>>
     return OneValue();
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 
diff --git a/Modules/Core/Common/include/itkNumericTraitsDiffusionTensor3DPixel.h b/Modules/Core/Common/include/itkNumericTraitsDiffusionTensor3DPixel.h
@@ -144,7 +144,7 @@ class NumericTraits<DiffusionTensor3D<T>>
     return Self(NumericTraits<T>::OneValue());
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 
diff --git a/Modules/Core/Common/include/itkNumericTraitsPointPixel.h b/Modules/Core/Common/include/itkNumericTraitsPointPixel.h
@@ -130,7 +130,7 @@ class NumericTraits<Point<T, D>>
     return OneValue();
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 
diff --git a/Modules/Core/Common/include/itkNumericTraitsRGBAPixel.h b/Modules/Core/Common/include/itkNumericTraitsRGBAPixel.h
@@ -170,7 +170,7 @@ class NumericTraits<RGBAPixel<T>>
     return NumericTraits<typename Self::LuminanceType>::IsNonnegative(val.GetLuminance());
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 
diff --git a/Modules/Core/Common/include/itkNumericTraitsRGBPixel.h b/Modules/Core/Common/include/itkNumericTraitsRGBPixel.h
@@ -170,7 +170,7 @@ class NumericTraits<RGBPixel<T>>
     return NumericTraits<typename Self::LuminanceType>::IsNonnegative(val.GetLuminance());
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 
diff --git a/Modules/Core/Common/include/itkNumericTraitsStdVector.h b/Modules/Core/Common/include/itkNumericTraitsStdVector.h
@@ -131,7 +131,7 @@ class NumericTraits<std::vector<T>>
     return b;
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 
diff --git a/Modules/Core/Common/include/itkNumericTraitsTensorPixel.h b/Modules/Core/Common/include/itkNumericTraitsTensorPixel.h
@@ -143,7 +143,7 @@ class NumericTraits<SymmetricSecondRankTensor<T, D>>
     return OneValue();
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 
diff --git a/Modules/Core/Common/include/itkNumericTraitsVariableLengthVectorPixel.h b/Modules/Core/Common/include/itkNumericTraitsVariableLengthVectorPixel.h
@@ -192,7 +192,7 @@ class NumericTraits<VariableLengthVector<T>>
     return flag;
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 
diff --git a/Modules/Core/Common/include/itkNumericTraitsVectorPixel.h b/Modules/Core/Common/include/itkNumericTraitsVectorPixel.h
@@ -185,7 +185,7 @@ class NumericTraits<Vector<T, D>>
     return flag;
   }
 
-  static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;
+  static constexpr bool IsSigned = std::is_signed<ValueType>::value;
   static constexpr bool IsInteger = std::is_integral<ValueType>::value;
   static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;
 
diff --git a/Modules/Core/Common/test/itkNumericTraitsTest.cxx b/Modules/Core/Common/test/itkNumericTraitsTest.cxx
@@ -210,17 +210,17 @@ CheckSignedAndIntegerTraitsSameAsSTDNumericLimits(const char * const name)
     std::cout << "\tERROR:  IsSigned definitions for itk::NumericTraits and std::numeric_limits do not match!! ERROR!!"
               << std::endl;
     std::cout << "\tFor type: \t" << name << std::endl;
-    std::cout << "\tITK signed Value for:\t<  " << name << "  >\tis:\t"
-              << (itk::NumericTraits<T>::IsSigned ? "true" : "false") << std::endl;
+    std::cout << "\tITK signed Value for:\t<  " << name << "  >\tis:\t" << (std::is_signed<T>::value ? "true" : "false")
+              << std::endl;
     std::cout << "\tstd signed Value for:\t<  " << name << "  >\tis:\t"
               << (std::numeric_limits<T>::is_signed ? "true" : "false") << std::endl;
     didTestPass = false;
   }
   else
   {
     std::cout << "\tSUCCESS:  IsSigned definition for itk::NumericTraits matches std::numeric_limits" << std::endl;
-    std::cout << "\tSigned Value for:\t<  " << name << "  >\tis:\t"
-              << (itk::NumericTraits<T>::IsSigned ? "true" : "false") << std::endl;
+    std::cout << "\tSigned Value for:\t<  " << name << "  >\tis:\t" << (std::is_signed<T>::value ? "true" : "false")
+              << std::endl;
   }
 
   // test for IsInteger

Original file line number	Diff line number	Diff line change
`@@ -1924,7 +1924,7 @@ class NumericTraits<std::complex<TComponent>>`
`1924`	`1924`	`return val.real() >= 0;`
`1925`	`1925`	`}`
`1926`	`1926`
`1927`		`- static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;`
	`1927`	`+ static constexpr bool IsSigned = std::is_signed<ValueType>::value;`
`1928`	`1928`	`static constexpr bool IsInteger = false;`
`1929`	`1929`	`static constexpr bool IsComplex = true;`
`1930`	`1930`	`static Self`
Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ class NumericTraits<Array<T>>`
`112`	`112`	`return b;`
`113`	`113`	`}`
`114`	`114`
`115`		`- static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;`
	`115`	`+ static constexpr bool IsSigned = std::is_signed<ValueType>::value;`
`116`	`116`	`static constexpr bool IsInteger = std::is_integral<ValueType>::value;`
`117`	`117`	`static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;`
`118`	`118`
Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ class NumericTraits<CovariantVector<T, D>>`
`143`	`143`	`return OneValue();`
`144`	`144`	`}`
`145`	`145`
`146`		`- static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;`
	`146`	`+ static constexpr bool IsSigned = std::is_signed<ValueType>::value;`
`147`	`147`	`static constexpr bool IsInteger = std::is_integral<ValueType>::value;`
`148`	`148`	`static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;`
`149`	`149`
Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ class NumericTraits<DiffusionTensor3D<T>>`
`144`	`144`	`return Self(NumericTraits<T>::OneValue());`
`145`	`145`	`}`
`146`	`146`
`147`		`- static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;`
	`147`	`+ static constexpr bool IsSigned = std::is_signed<ValueType>::value;`
`148`	`148`	`static constexpr bool IsInteger = std::is_integral<ValueType>::value;`
`149`	`149`	`static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;`
`150`	`150`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ class NumericTraits<Point<T, D>>`
`130`	`130`	`return OneValue();`
`131`	`131`	`}`
`132`	`132`
`133`		`- static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;`
	`133`	`+ static constexpr bool IsSigned = std::is_signed<ValueType>::value;`
`134`	`134`	`static constexpr bool IsInteger = std::is_integral<ValueType>::value;`
`135`	`135`	`static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;`
`136`	`136`
Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ class NumericTraits<RGBAPixel<T>>`
`170`	`170`	`return NumericTraits<typename Self::LuminanceType>::IsNonnegative(val.GetLuminance());`
`171`	`171`	`}`
`172`	`172`
`173`		`- static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;`
	`173`	`+ static constexpr bool IsSigned = std::is_signed<ValueType>::value;`
`174`	`174`	`static constexpr bool IsInteger = std::is_integral<ValueType>::value;`
`175`	`175`	`static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;`
`176`	`176`
Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ class NumericTraits<std::vector<T>>`
`131`	`131`	`return b;`
`132`	`132`	`}`
`133`	`133`
`134`		`- static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;`
	`134`	`+ static constexpr bool IsSigned = std::is_signed<ValueType>::value;`
`135`	`135`	`static constexpr bool IsInteger = std::is_integral<ValueType>::value;`
`136`	`136`	`static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;`
`137`	`137`
Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ class NumericTraits<VariableLengthVector<T>>`
`192`	`192`	`return flag;`
`193`	`193`	`}`
`194`	`194`
`195`		`- static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;`
	`195`	`+ static constexpr bool IsSigned = std::is_signed<ValueType>::value;`
`196`	`196`	`static constexpr bool IsInteger = std::is_integral<ValueType>::value;`
`197`	`197`	`static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;`
`198`	`198`
Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ class NumericTraits<Vector<T, D>>`
`185`	`185`	`return flag;`
`186`	`186`	`}`
`187`	`187`
`188`		`- static constexpr bool IsSigned = NumericTraits<ValueType>::IsSigned;`
	`188`	`+ static constexpr bool IsSigned = std::is_signed<ValueType>::value;`
`189`	`189`	`static constexpr bool IsInteger = std::is_integral<ValueType>::value;`
`190`	`190`	`static constexpr bool IsComplex = NumericTraits<ValueType>::IsComplex;`
`191`	`191`