BUG: VersorTransform did not update offset in SetParameters

InsightSoftwareConsortium · Oct 10, 2021 · fb64eb2 · fb64eb2
1 parent f66267b
commit fb64eb2
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/Modules/Core/Transform/include/itkVersorTransform.hxx b/Modules/Core/Transform/include/itkVersorTransform.hxx
@@ -73,6 +73,7 @@ VersorTransform<TParametersValueType>::SetParameters(const ParametersType & para
   itkDebugMacro(<< "Versor is now " << m_Versor);
 
   this->ComputeMatrix();
+  this->ComputeOffset();
 
   // Modified is always called since we just have a pointer to the
   // parameters and cannot know if the parameters have changed.

diff --git a/Modules/Core/Transform/test/itkVersorTransformTest.cxx b/Modules/Core/Transform/test/itkVersorTransformTest.cxx
@@ -469,6 +469,35 @@ itkVersorTransformTest(int, char *[])
       }
     }
 
+    {
+      // Check that setting parameters updates the transformation offset
+      t = TransformType::New();
+
+      const TransformType::InputPointType center = itk::MakePoint(2, 4, 8);
+
+      // 90 degree rotation around x axis
+      ParametersType q(3);
+      q[0] = itk::Math::sqrt1_2;
+      q[1] = 0.0;
+      q[2] = 0.0;
+
+      t->SetCenter(center);
+      t->SetParameters(q);
+
+      const double expectedOffset[] = { 0.0, 12.0, 4.0 };
+
+      TransformType::OffsetType offset = t->GetOffset();
+      for (unsigned int k = 0; k < 3; ++k)
+      {
+        if (std::fabs(expectedOffset[k] - offset[k]) > epsilon)
+        {
+          std::cerr << " [ FAILED ] " << std::endl;
+          std::cerr << "Expected offset: " << expectedOffset << std::endl;
+          std::cerr << "but got: " << offset << std::endl;
+          return EXIT_FAILURE;
+        }
+      }
+    }
     {
       TransformType::Pointer tInverse = TransformType::New();
       if (!t->GetInverse(tInverse))