Skip to content

Commit 79afb4b

Browse files
a7medevahmedAlaaInstabug
authored andcommitted
fix(android): resolve an OOM in network logs (#1244)
1 parent f2197b8 commit 79afb4b

File tree

2 files changed

+20
-27
lines changed

2 files changed

+20
-27
lines changed

CHANGELOG.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,8 @@
22

33
## [Unreleased](https://github.com/Instabug/Instabug-React-Native/compare/v13.2.0...dev)
44

5-
### Added
6-
7-
- Export `uploadSourcemaps` and `uploadSoFiles` utilities in the `instabug-reactnative/upload` sub-package for usage in custom Node.js upload scripts ([#1252](https://github.com/Instabug/Instabug-React-Native/pull/1252)).
8-
95
### Fixed
106

11-
- Fix APM network logging on Android ([#1253](https://github.com/Instabug/Instabug-React-Native/pull/1253)).
127
- Fix an OOM (out-of-memory) crash while saving network logs on Android ([#1244](https://github.com/Instabug/Instabug-React-Native/pull/1244)).
138

149
## [13.2.0](https://github.com/Instabug/Instabug-React-Native/compare/v13.1.1...v13.2.0) (July 7, 2024)

android/src/main/java/com/instabug/reactlibrary/RNInstabugAPMModule.java

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import com.instabug.apm.APM;
1515
import com.instabug.apm.model.ExecutionTrace;
1616
import com.instabug.apm.networking.APMNetworkLogger;
17-
import com.instabug.apm.networkinterception.cp.APMCPNetworkLog;
1817
import com.instabug.reactlibrary.utils.MainThreadHandler;
1918

2019
import org.json.JSONException;
@@ -339,28 +338,27 @@ private void networkLogAndroid(final double requestStartTime,
339338
final String errorMessage = hasError ? errorDomain : null;
340339

341340
try {
342-
Method method = getMethod(Class.forName("com.instabug.apm.networking.APMNetworkLogger"), "log", long.class, long.class, String.class, String.class, long.class, String.class, String.class, String.class, String.class, String.class, long.class, int.class, String.class, String.class, String.class, String.class, APMCPNetworkLog.W3CExternalTraceAttributes.class);
341+
Method method = getMethod(Class.forName("com.instabug.apm.networking.APMNetworkLogger"), "log", long.class, long.class, String.class, String.class, long.class, String.class, String.class, String.class, String.class, String.class, long.class, int.class, String.class, String.class, String.class, String.class);
343342
if (method != null) {
344-
method.invoke(
345-
networkLogger,
346-
(long) requestStartTime,
347-
(long) requestDuration,
348-
requestHeaders,
349-
requestBody,
350-
(long) requestBodySize,
351-
requestMethod,
352-
requestUrl,
353-
requestContentType,
354-
responseHeaders,
355-
responseBody,
356-
(long)responseBodySize,
357-
(int) statusCode,
358-
responseContentType,
359-
errorMessage,
360-
gqlQueryName,
361-
serverErrorMessage,
362-
null
363-
);
343+
method.invoke(
344+
networkLogger,
345+
requestStartTime,
346+
requestDuration,
347+
requestHeaders,
348+
requestBody,
349+
requestBodySize,
350+
requestMethod,
351+
requestUrl,
352+
requestContentType,
353+
responseHeaders,
354+
responseBody,
355+
responseBodySize,
356+
statusCode,
357+
responseContentType,
358+
errorMessage,
359+
gqlQueryName,
360+
serverErrorMessage
361+
);
364362
} else {
365363
Log.e("IB-CP-Bridge", "APMNetworkLogger.log was not found by reflection");
366364
}

0 commit comments

Comments
 (0)