-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash with embedded CollectionView #699
Comments
@shuhrat10 do you have an example reproducing this issue? We had this happen internally this week and it ended up being implementation error. When are you attaching the collection view to the adapter? |
Hi @rnystrom, I don't have an example with this issue. It's happen in our new project today, and I wont be able to reproduce this crash. But I will keep testing to try reproduce this issue. In viewDidLoad I set:
and then
I don't need to execute adapter.performUpdates(animated: true) because I all data ready for use before this controller will be initialized. |
@shuhrat10 where/how is the embedded adapter's collection view set? |
In ViewController I have:
PlaylistItemsController is not used at this time. |
@rnystrom on tvOS you can super fast switch between sections and items with Siri Remote. |
|
@shuhrat10 can you print the description of the embedded You can also just |
@rnystrom See bellow
|
@rnystrom do you have any thoughts what is causing this crash? |
@shuhrat10 ran into this internally as well, digging into this, sorry for the delay, something is out of whack 🤕 |
@shuhrat10 I put together this example project trying to reproduce your conditions and can't get anything to crash on a real device or simulator. Could you take a look at this and let me know if there is something missing in the setup that could reproduce the crash? If you can get it to crash, mind re-uploading it? edit: Aha! I got a sort-of repro. I don't know how to do it 100%, but I can eventually get it to crash. Diagnosing and fixing now. edit2: Found the bug, PR incoming |
Hi,
I have CollectionView with embedded horizontal CollectionView. For example:
Category 1:
Items [Horizontal collectionView]
Category 2:
Items [Horizontal collectionView]
e.t.c.
When I start moving between sections and items my application crashed. It's not happening all the time. I'm not reloading any section, I think it's happening automatically when you move from top to the end. Any idea what can cause this issue? See attached screenshot for more details:
I'm using latest Xcode 8.3.2 and IGListKit from master branch. commit: ee4f3c9
Thank you.
The text was updated successfully, but these errors were encountered: