Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for ASDK, ComponentKit, etc. #94

Closed
4 tasks
jessesquires opened this issue Oct 20, 2016 · 14 comments
Closed
4 tasks

Add examples for ASDK, ComponentKit, etc. #94

jessesquires opened this issue Oct 20, 2016 · 14 comments

Comments

@jessesquires
Copy link
Contributor

jessesquires commented Oct 20, 2016

Follow up task from #86.

Add examples using:

  • ComponentKit
  • AsyncDisplayKit
  • UIKit
  • WKWebView

⚠️ If submitting a PR, please submit 1 PR per type of example

@rnystrom
Copy link
Contributor

rnystrom commented Oct 23, 2016

@jessesquires are you gonna work on this?

@jessesquires jessesquires removed their assignment Oct 24, 2016
@jessesquires
Copy link
Contributor Author

lol. didn't mean to self-assign

@saraswatayu
Copy link
Contributor

saraswatayu commented Oct 28, 2016

In #86, @rnystrom mentioned using ComponentKit, AsyncDisplayKit, UIKit, and WKWebView within the same list. Is that still the goal or should four different lists be created, each using one of the aforementioned frameworks?

@ocrickard
Copy link

Here's my stab at simple ComponentKit integration: https://github.com/ocrickard/IGListKit-ComponentKit/blob/master/IGListKit-ComponentKit/CKComponentSectionController.mm

This has an item controller that can render an arbitrary number of sub-elements using ComponentKit. Uses async processing of components by default, but could easily be changed to support synchronous/asynchronous modes.

@jessesquires
Copy link
Contributor Author

@ocrickard / @rnystrom

We could add a CocoaPods subspec with a dependency on ComponentKit and add these IGLK+ComponentKit components (assuming they're reusable)

@rnystrom
Copy link
Contributor

Would be super cool to explore

@stevejcox
Copy link

stevejcox commented Jan 10, 2017

Has anyone taken a look at creating the AsyncDisplayKit example? Looking to try and improve feed performance and interested in anyones experience.

@Sherlouk
Copy link
Contributor

@stevejcox To my knowledge @Adlai-Holler was looking into this?

Mentioned it here: #375

@Adlai-Holler
Copy link
Contributor

@stevejcox Hi, yep we've got it up and running, with an example. We're looking for comments, so please give it a try if you want! facebookarchive/AsyncDisplayKit#2848

@stevejcox
Copy link

Fantastic @Adlai-Holler ! I'll give it a whirl.

@Sherlouk
Copy link
Contributor

@jessesquires @rnystrom

Are we still wanting to bring examples into this repo? As linked there are examples for two of the listed tasks:

If so, do we want them as a different project file entirely, or add it all to the Examples-iOS project?

We could add a CocoaPods subspec with a dependency on ComponentKit

Do we want to do this (IGListKit/ComponentKit)? Same for ASDK (IGListKit/AsyncDisplayKit)?

@MarvinNazari
Copy link
Contributor

@Sherlouk: there is another ASDK example here, pretty similar to the IGListKit search example https://github.com/facebook/AsyncDisplayKit/tree/master/examples_extra/RepoSearcher

@Sherlouk
Copy link
Contributor

@MarvinNazari Thanks for linking that one. hadn't seen it! Much easier to move over (already in Swift)

@rnystrom
Copy link
Contributor

B/c there are existing and examples, and we want to limit the scope of things we support within the repo directly, I'm going to close this out. Those examples are great, and I'm happy to promote and link to more as they come up. Just don't want to get our examples overly complicated for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants