-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples for ASDK, ComponentKit, etc. #94
Comments
@jessesquires are you gonna work on this? |
lol. didn't mean to self-assign |
Here's my stab at simple ComponentKit integration: https://github.com/ocrickard/IGListKit-ComponentKit/blob/master/IGListKit-ComponentKit/CKComponentSectionController.mm This has an item controller that can render an arbitrary number of sub-elements using ComponentKit. Uses async processing of components by default, but could easily be changed to support synchronous/asynchronous modes. |
We could add a CocoaPods subspec with a dependency on ComponentKit and add these IGLK+ComponentKit components (assuming they're reusable) |
Would be super cool to explore |
Has anyone taken a look at creating the AsyncDisplayKit example? Looking to try and improve feed performance and interested in anyones experience. |
@stevejcox To my knowledge @Adlai-Holler was looking into this? Mentioned it here: #375 |
@stevejcox Hi, yep we've got it up and running, with an example. We're looking for comments, so please give it a try if you want! facebookarchive/AsyncDisplayKit#2848 |
Fantastic @Adlai-Holler ! I'll give it a whirl. |
Are we still wanting to bring examples into this repo? As linked there are examples for two of the listed tasks:
If so, do we want them as a different project file entirely, or add it all to the
Do we want to do this ( |
@Sherlouk: there is another ASDK example here, pretty similar to the IGListKit search example https://github.com/facebook/AsyncDisplayKit/tree/master/examples_extra/RepoSearcher |
@MarvinNazari Thanks for linking that one. hadn't seen it! Much easier to move over (already in Swift) |
B/c there are existing and examples, and we want to limit the scope of things we support within the repo directly, I'm going to close this out. Those examples are great, and I'm happy to promote and link to more as they come up. Just don't want to get our examples overly complicated for now. |
Follow up task from #86.
Add examples using:
The text was updated successfully, but these errors were encountered: