Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing wheels for musl (alpine 3.17) #962

Closed
gmile opened this issue Jun 22, 2023 · 3 comments · Fixed by #1243
Closed

Publishing wheels for musl (alpine 3.17) #962

gmile opened this issue Jun 22, 2023 · 3 comments · Fixed by #1243
Labels
enhancement New feature or request

Comments

@gmile
Copy link

gmile commented Jun 22, 2023

The library can be built on musl with no issues currently. Confirmed by building it using alpine:3.17 as a base image:

FROM alpine:3.17 AS build

WORKDIR /tmp

RUN apk add \
  git \
  cargo \
  py-pip

RUN pip3 install \
  setuptools_rust \
  wheel

RUN apk add git cargo py-pip; \
    pip3 install setuptools_rust wheel; \
    git clone --depth 1 --branch v1.0.0 https://github.com/Instagram/LibCST /tmp; \
    cd LibCST; python setup.py bdist_wheel

FROM scratch AS export

COPY --from=build /tmp/dist/libcst-1.0.0-cp310-cp310-linux_x86_64.whl .

Could building & publishing a wheel be enbled for musl? 🙏 This would save some hassle for people who just want to install it using pip (myself included).

@zsol
Copy link
Member

zsol commented Jun 22, 2023

Happy to accept a PR!

@zsol zsol added the enhancement New feature or request label Jul 12, 2023
@MrMino
Copy link
Contributor

MrMino commented Nov 18, 2024

@zsol is it possible to append the v1.5.0 release with musllinux tagged wheels? Or have a release v1.5.1 with all of them? Or would you rather wait for the next minor version of libcst?

@zsol
Copy link
Member

zsol commented Nov 18, 2024

1.5.1 is on the way: https://github.com/Instagram/LibCST/actions/runs/11900399311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants