New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc build error #1221

Merged

zsol merged 1 commit into main from pr1221

Oct 10, 2024

GitHub Actions / clippy succeeded Oct 10, 2024 in 4s

clippy

212 warnings

Details

Results

Message level	Amount
Internal compiler error	0
Error	0
Warning	212
Note	0
Help	0

Versions

rustc 1.81.0 (eeb90cda1 2024-09-04)
cargo 1.81.0 (2dbb1af80 2024-08-20)
clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 29 in libcst/src/bin.rs

github-actions / clippy

`to_string` applied to a type that implements `Display` in `print!` args

warning: `to_string` applied to a type that implements `Display` in `print!` args
  --> libcst/src/bin.rs:29:35
   |
29 |                 print!("{}", state.to_string());
   |                                   ^^^^^^^^^^^^ help: remove this
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
   = note: `#[warn(clippy::to_string_in_format_args)]` on by default

Check warning on line 22 in libcst/src/bin.rs

github-actions / clippy

use of `unwrap_or_else` to construct default value

warning: use of `unwrap_or_else` to construct default value
  --> libcst/src/bin.rs:22:48
   |
22 |             let first_arg = env::args().nth(1).unwrap_or_else(|| "".to_string());
   |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
   = note: `#[warn(clippy::unwrap_or_default)]` on by default

Check warning on line 3481 in libcst/src/parser/grammar.rs

github-actions / clippy

manual implementation of `Option::map`

warning: manual implementation of `Option::map`
    --> libcst/src/parser/grammar.rs:3477:24
     |
3477 |       let lbracket_tok = if let Some(tp) = &type_parameters {
     |  ________________________^
3478 | |         Some(tp.lbracket.tok)
3479 | |     } else {
3480 | |         None
3481 | |     };
     | |_____^ help: try: `type_parameters.as_ref().map(|tp| tp.lbracket.tok)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
     = note: `#[warn(clippy::manual_map)]` on by default

Check warning on line 1898 in libcst/src/parser/grammar.rs

github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
    --> libcst/src/parser/grammar.rs:1898:25
     |
1898 |     a.into_iter().chain(b.into_iter()).collect()
     |                         ^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `b`
     |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
    --> /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/iter/traits/iterator.rs:484:12
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
     = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 81 in libcst/src/parser/errors.rs

github-actions / clippy

this lifetime isn't used in the impl

warning: this lifetime isn't used in the impl
  --> libcst/src/parser/errors.rs:81:10
   |
81 |     impl<'a> PyErrArguments for Details {
   |          ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
   = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default

Check warning on line 103 in libcst/src/nodes/traits.rs

github-actions / clippy

`?Sized` bound is ignored because of a `Sized` requirement

warning: `?Sized` bound is ignored because of a `Sized` requirement
   --> libcst/src/nodes/traits.rs:103:27
    |
103 | impl<'a, T: Inflate<'a> + ?Sized> Inflate<'a> for Box<T> {
    |                           ^^^^^^
    |
note: `T` cannot be unsized because of the bound
   --> libcst/src/nodes/traits.rs:103:13
    |
103 | impl<'a, T: Inflate<'a> + ?Sized> Inflate<'a> for Box<T> {
    |             ^^^^^^^^^^^
    = note: ...because `Inflate` has the bound `Sized`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized
    = note: `#[warn(clippy::needless_maybe_sized)]` on by default
help: change the bounds that require `Sized`, or remove the `?Sized` bound
    |
103 - impl<'a, T: Inflate<'a> + ?Sized> Inflate<'a> for Box<T> {
103 + impl<'a, T: Inflate<'a>> Inflate<'a> for Box<T> {
    |

Check warning on line 63 in libcst/src/nodes/module.rs