Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Perturber inherit from LitModular #117

Open
dxoigmn opened this issue Mar 24, 2023 · 0 comments
Open

Make Perturber inherit from LitModular #117

dxoigmn opened this issue Mar 24, 2023 · 0 comments

Comments

@dxoigmn
Copy link
Contributor

dxoigmn commented Mar 24, 2023

          Why can't this be a `LitModular`? Then we inherit all of the optimizer functionality. The problem, I think, is the modules functionality. However, that should, in theory, cleanup the use of objective and gain since we can treat them as modules?

As I thought about this more, it would be really nice for this to be a LitModular because then this code could be used to generate attacks using the Lightning framework. That is, we could run the validation loop to test the efficacy of the attack after every epoch and run the test loop at the end too.

Originally posted by @dxoigmn in #103 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant