Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume LitModular by default in configuration #190

Open
dxoigmn opened this issue Jul 6, 2023 · 0 comments
Open

Assume LitModular by default in configuration #190

dxoigmn opened this issue Jul 6, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@dxoigmn
Copy link
Contributor

dxoigmn commented Jul 6, 2023

Right now our configuration is rather verbose when it comes to models:

model:
  _target_: mart.models.LitModular
  _convert_: all
  output_preds_key: preds
  output_target_key: target
  modules:
    ...
  training_sequence:
    ...
  ...

We could clean this up by assuming LitModular by default and moving all keys under model up 1 level like:

output_preds_key: preds
output_target_key: target
modules:
  ...
training_sequence:
  ...
...
@dxoigmn dxoigmn added the enhancement New feature or request label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dxoigmn