Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ChainedSchedulers in LitModular. #191

Open
dxoigmn opened this issue Jul 10, 2023 · 0 comments
Open

Add support for ChainedSchedulers in LitModular. #191

dxoigmn opened this issue Jul 10, 2023 · 0 comments

Comments

@dxoigmn
Copy link
Contributor

dxoigmn commented Jul 10, 2023 •
edited
Loading

Right now LitModular does not support ChainedScheduler. This is because a ChainedScheduler does not take an optimizer, but rather a list of schedulers:
https://pytorch.org/docs/stable/generated/torch.optim.lr_scheduler.ChainedScheduler.html

LitModular assumes lr_scheduler is a callable that receives an Optimizer:

MART/mart/models/modular.py

Line 122 in 41ad18e

config["lr_scheduler"] = self.lr_scheduler(config["optimizer"])

My sense is the best way to fix this is to allow lr_scheduler to be a list and we can create the underlying ChainedScheduler within LitModular.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dxoigmn