Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between configuration and code in the Missed objective of object detection #23

Open
mzweilin opened this issue Dec 13, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@mzweilin
Copy link
Contributor

arg_keys:
- preds
kwarg_keys: null

def __call__(self, preds, target):

The code requires preds and target, but the configuration only gives preds. Since target is not used in the objective function, we can either delete it from __call__()'s argument list, or add an unused parameter target in the configuration.

@mzweilin mzweilin added the bug Something isn't working label Dec 13, 2022
@dxoigmn
Copy link
Contributor

dxoigmn commented Jun 22, 2023

This is partially related to #178. We should probably just remove the use of CallWith here. It was meant to be an internal class anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants